Download progress bar and checking for botpack updates #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A message stating that it is not dismissable and why should be shown, also a timer, but double its theoretical ammount it so people dont get annoyed if it lasts a bit longer, but get happy for it lasting less |
tarehart
approved these changes
Sep 24, 2019
The timer seems unnecessary to me, since the download takes only a few minutes and it's easy for a person to judge how long it will take the progress bar to move across. I'll leave it up to Darxeal whether he wants to address these in a future PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a progress bar while downloading the botpack:
The dialog is intentionally non-dismissable, because users shouldn't be starting matches during the download (bot files will get deleted).
I also added checking if there is a newer version of the botpack available, using the GitHub API.
All users will get the snackbar notification when they get this update for the first time, but I think that's alright, because 99% people don't have the latest botpack anyway.