add remaining rlbot interface functions + one example #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehsanul
commented
Sep 19, 2018
ehsanul
force-pushed
the
flesh_out_rlbot_interface
branch
from
e4a63eb
to
f9becef
Compare
ehsanul
commented
Sep 19, 2018
ehsanul
commented
Sep 19, 2018
ehsanul
force-pushed
the
flesh_out_rlbot_interface
branch
2 times, most recently
from
8ddc4ae
to
7b1ebeb
Compare
whatisaphone
requested changes
Sep 23, 2018
src/dll.rs
Outdated
| pub set_game_state: SetGameState, | ||
| pub render_group: RenderGroup, | ||
| pub send_chat: SendChat, | ||
| /// flatbuffer version of send_chat |
There was a problem hiding this comment.
nit: Can you capitalize this properly? (even though it's not public)
ehsanul
force-pushed
the
flesh_out_rlbot_interface
branch
3 times, most recently
from
d235d8e
to
bcf62c5
Compare
ehsanul
force-pushed
the
flesh_out_rlbot_interface
branch
from
bcf62c5
to
9be6058
Compare
|
@whatisaphone Thanks for reviewing. I've made your suggested changes, should be good to go now! |
whatisaphone
approved these changes
Sep 25, 2018
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.