-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/cdp session with eventemitter #38
Conversation
this avoir infinite recursion with newListener for example
This reverts commit a504cb9.
Aim: keep trace of in dev testing
and add debug code to help diagnosis
Merge branch 'master' into feature/CDPSession-with-eventemitter # Conflicts: # R/eventemitters.R # man/EventEmitter.Rd
I am really embarrassed by Lines 27 to 32 in 224df2f
There are two kinds of messages sent by Chrome:
With this implementation, the I would prefer to keep the distinction between Chrome events and Chrome responses: I will propose some changes in this direction. |
It was my understanding that only commands have id. These lines are just emitting the event corresponding to the command sent. Lines after are responding the same way but to method. |
What do you think of that? |
Definitely looks good ! It is fine by me. |
I open this PR now in order to have a room for discussion for this branch.