Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase rest-client version to non-vulnerable one #56

Merged
merged 1 commit into from
Jan 8, 2016

Conversation

mathieujobin
Copy link
Contributor

@mathieujobin
Copy link
Contributor Author

ping

@RLovelett
Copy link
Owner

I'm not sure how I feel about the switch from ~> to >=. Why is that necessary? I'd prefer to lock it to anything in the 1.8.x branch rather than anything greater.

Please switch it back to ~> unless you can provide a compelling argument as to why >= is better.

The version bump is a no brainer otherwise.

@mathieujobin
Copy link
Contributor Author

I found that ~> is better for locking down dependencies on apps, and >= is better (less restrictive) on gems. I had issues with too restrictive conflicting gems

then the other question is do we want/need to forbid the 2.0.0 release coming up ?

@RLovelett
Copy link
Owner

That seems reasonable. See that is why I always prefer the ~> I am never up-to-date enough to know what 2.0.0 will break if it's allowed and I just always find it easier to say give me the one that I know (read: tested) it to work with.

I guess we'll just go to >= and if 2.0.0 breaks something people can submit a patch? Seems reasonable. What do you think?

RLovelett added a commit that referenced this pull request Jan 8, 2016
Drop support for vulnerable rest-client version
@RLovelett RLovelett merged commit 8a98244 into RLovelett:master Jan 8, 2016
@mathieujobin mathieujobin deleted the update_rest_client branch January 12, 2016 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants