Skip to content
This repository has been archived by the owner on Dec 14, 2023. It is now read-only.

add_bics_sector via fin data and bics_bridge data #77

Closed
wants to merge 2 commits into from

Conversation

jacobvjk
Copy link
Member

  • My previous attempt to re-introduce bics sectors may produce duplicate entries in the portfolio due to non-unique bics entries.
  • In this commit I revert to the original idea of using a bics_bridge file to map the holdings and bics sectors.
  • the bridge is not complete yet and in general it seems unclear if it is a great choice to use bics, but for the time being, I guess we no alternatives, as this is promised to be part of pacta 2020 afaik.

@jacobvjk
Copy link
Member Author

I also tried to finally get rid of these horrendous .DS_Store files but, although they are in my .gitignore file, they keep returning and somehow mess up this PR... @maurolepore I'm sure you know what I'm not seeing here?

@maurolepore
Copy link
Contributor

Try usethis::git_vaccinate(): https://usethis.r-lib.org/reference/git_vaccinate.html

@jacobvjk
Copy link
Member Author

Still not really working.. I mean I don't understand how this is a conflict anyway..

@maurolepore
Copy link
Contributor

Now re-reading this thread: https://github.com/2DegreesInvesting/resources/issues/115
...

@maurolepore
Copy link
Contributor

So it looks like CJ's last comment is your best bet: https://github.com/2DegreesInvesting/resources/issues/115#issuecomment-608579867

I think:

git config --global core.excludesfile .DS_Store

@jacobvjk jacobvjk mentioned this pull request Sep 10, 2020
@jacobvjk
Copy link
Member Author

tired the last one, but this was messy, so I quickly moved it all to a new branch and new PR #78... Closing this one.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants