You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are two "sector defining columns" in the match_result input: sector and sector_ald.
sector comes from the loanbook specification
sector_ald comes from the asset-level data
In the analysis, we should only ever use the actual data in the sector_ald column. From what I can tell, this is already happening, however, internally, we are joining and renaming and abusing the word sector when we mean sector_ald.
I think we should decide on a consistent method, so that we don't confuse people (and ourselves).
Options:
Drop sector as soon as data is input, and rename sector = sector_ald
Try to keep track of sector_ald and not accidentally reference the wrong column
The text was updated successfully, but these errors were encountered:
…tasets (#179)
Closes#178
We confused sector and sector_ald in a few places.
This was effectively a silent error, since we are only
allowing for `r2dii.match::match_name(..., by_sector = TRUE)`.
There are two "sector defining columns" in the
match_result
input:sector
andsector_ald
.sector
comes from the loanbook specificationsector_ald
comes from the asset-level dataIn the analysis, we should only ever use the actual data in the
sector_ald
column. From what I can tell, this is already happening, however, internally, we are joining and renaming and abusing the wordsector
when we meansector_ald
.I think we should decide on a consistent method, so that we don't confuse people (and ourselves).
Options:
sector
as soon as data is input, and renamesector = sector_ald
sector_ald
and not accidentally reference the wrong columnThe text was updated successfully, but these errors were encountered: