Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

breaking change: replace the concept of id_2dii with the AI specific company ID #212

Closed
jdhoffa opened this issue Jun 12, 2020 · 3 comments
Closed

breaking change: replace the concept of id_2dii with the AI specific company ID #212

jdhoffa opened this issue Jun 12, 2020 · 3 comments
Assignees
@jdhoffa
Labels
breaking change ☠️ API change likely to affect existing code feature a feature request or enhancement

Comments

@jdhoffa
Copy link
Member

jdhoffa commented Jun 12, 2020

Since id_2dii is just every unique combo of name+sector, we can just as easily uniquely identify companies based on this.

Seems easier to do in practice.
@georgeharris2deg georgeharris2deg mentioned this issue Dec 9, 2020
Closed
@jdhoffa jdhoffa added the bug an unexpected problem or unintended behavior label May 19, 2023
@jdhoffa jdhoffa added ADO Add issue to ADO and removed priority labels Jan 26, 2024
@jdhoffa jdhoffa self-assigned this Jan 26, 2024
@jdhoffa jdhoffa added feature a feature request or enhancement and removed bug an unexpected problem or unintended behavior labels Jan 29, 2024
@jdhoffa
Copy link
Member Author

jdhoffa commented Jan 29, 2024

This isn't a bug (everything works as expected), but rather a feature request as it would be nice to not use id_2dii. Re-labeled accordingly

@jdhoffa jdhoffa added the breaking change ☠️ API change likely to affect existing code label Feb 6, 2024
@jdhoffa
Copy link
Member Author

jdhoffa commented Feb 6, 2024

I fear this may be a breaking change... consider appropriately.

@jdhoffa jdhoffa mentioned this issue Feb 6, 2024
Open
@jdhoffa jdhoffa changed the title In overwrite_demo, use name_company instead of id_2dii breaking change: replace the concept of id_2dii with the AI specific company ID Mar 6, 2024
@jdhoffa jdhoffa removed the ADO Add issue to ADO label Mar 6, 2024
@jdhoffa
Copy link
Member Author

jdhoffa commented Mar 6, 2024

Closing as duplicate of #375

@jdhoffa jdhoffa closed this as completed Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdhoffa jdhoffa

Labels
breaking change ☠️ API change likely to affect existing code feature a feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jdhoffa