Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

match_name() should output the column borderline #258

Closed
jdhoffa opened this issue Aug 6, 2020 · 5 comments
Closed

match_name() should output the column borderline #258

jdhoffa opened this issue Aug 6, 2020 · 5 comments

Comments

@jdhoffa
Copy link
Member

jdhoffa commented Aug 6, 2020

r2dii.data has a series of sector code classification datafiles, each of which has a column borderline. This flag is FALSE if the sector classification code perfectly aligns with a 2dii sector, and TRUE if the sector may include one, but might not.

This would be a good column to output, as it can be used to determine the coverage of the matching easily.

This PR should inlude an article explaining borderline

@maurolepore
Copy link
Contributor

Should we include this in the upcoming release?

@jdhoffa
Copy link
Member Author

jdhoffa commented Aug 6, 2020

I think it wouldn't hurt.

@jdhoffa
Copy link
Member Author

jdhoffa commented Aug 6, 2020

It should be as simple as adding it to a call to select(). If it seems like it will take longer than ~10min, then I would say forget about it, and proceed with the release

@maurolepore
Copy link
Contributor

I agree, the change should be quick and safe. What might take longer is the article. If you want it in the same PR, I’d appreciate your help. Else, we can show the feature in the blog post that announces the release.

@jdhoffa
Copy link
Member Author

jdhoffa commented Aug 6, 2020

Absolutely, I can help today if you'd like to work on it together

maurolepore added a commit to maurolepore/r2dii.match that referenced this issue Aug 6, 2020
@jdhoffa jdhoffa closed this as completed in ed9d044 Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants