Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prefer_perfect_match_by() should be an argument #61

Closed
maurolepore opened this issue Jan 2, 2020 · 0 comments
Closed

prefer_perfect_match_by() should be an argument #61

maurolepore opened this issue Jan 2, 2020 · 0 comments

Comments

@maurolepore
Copy link
Contributor

This adds flexibility and should allow to document this feature in a maintainable way. If I don't make it an argument I should document this feature, but then it's hard to keep the documentation in sync with the feature -- if I later remove the feature there would be nothing during checks that will remind me to update the documentation.
@maurolepore maurolepore mentioned this issue Jan 4, 2020
Closed
maurolepore added a commit to maurolepore/r2dii.match that referenced this issue Jan 6, 2020
@maurolepore
Document prefer_perfect_match_by
d3332a6 
Closes RMI-PACTA#61

I finally decided to document this in @return instead of in a new
argument.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@maurolepore