Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NetEase UU Game Accelerator model type #712

Merged
merged 1 commit into from Mar 8, 2021
Merged

Fix NetEase UU Game Accelerator model type #712

merged 1 commit into from Mar 8, 2021

Conversation

VirgilClyne
Copy link
Contributor

@VirgilClyne VirgilClyne commented Mar 3, 2021

When the type is "asuswrt", the Accelerator web UI show "The router fails to connect to the network" and can't work as expected
Modify the URL to "type=asuswrt-merlin", it work normally again
tested on AC88u AX88u AC86u AX86u AC1900P

refer:

router type define
install.sh from https://router.uu.163.com/api/script/install?type=asuswrt-merlin
uuplugin_monitor.sh from https://router.uu.163.com/api/script/monitor?type=asuswrt-merlin

fourm solution discussion
https://koolshare.cn/forum.php?mod=redirect&goto=findpost&ptid=179485&pid=2417559
https://koolshare.cn/forum.php?mod=viewthread&tid=179485
https://koolshare.cn/forum.php?mod=redirect&goto=findpost&ptid=192048&pid=2515316

@RMerl
Copy link
Owner

RMerl commented Mar 3, 2021

What issue does this resolve?

@RMerl RMerl merged commit 7023800 into RMerl:master Mar 8, 2021
@paldier
Copy link
Contributor

paldier commented Mar 8, 2021

Don't use "asuswrt-merlin", asus device use "asuswrt", asus device support asus‘s uu(has auth, support more features), third party could not pass verification, so non-asus use "asuswrt-merlin"(netease's uu).

@VirgilClyne
Copy link
Contributor Author

VirgilClyne commented Mar 8, 2021

Don't use "asuswrt-merlin", asus device use "asuswrt", asus device support asus‘s uu(has auth, support more features), third party could not pass verification, so non-asus use "asuswrt-merlin"(netease's uu).

Source request and which asus models use "asuswrt" pass verification on asuswrt-merlin.ng firmware
And in all my fourm solution discussion links, their all devices are ASUS’s
Maybe you confuse the Accelerator's router built-in version with the plug-in version(APP-install version)

@paldier
Copy link
Contributor

paldier commented Mar 8, 2021

If you want to fix this problem, move exec_uu() from ntp.c to services.c, see start_qmacc(), just like it. uu and qmacc only work when tcode is CN, it is safe.

@VirgilClyne
Copy link
Contributor Author

VirgilClyne commented Mar 9, 2021

If you want to fix this problem, move exec_uu() from ntp.c to services.c, see start_qmacc(), just like it. uu and qmacc only work when tcode is CN, it is safe.

First, All Accelerator (UU Game Booster and Tencent Game Accelerator) we discuss are firmware embedded edition (both have web control interface and app control interface, can remote control in the internet, not APP install plugin edition (only can control with APP in the same local area network).

As u know, merlin Use NTP daemon(ntpd)
u are a famous mod firmware author that base on asus official firmware, not base on merlin (refer u patch note: https://update.paldier.com/log.txt and u blog:https://blog.paldier.com/)
Allmost all u firmware release article's first sentence is “基于华硕官方源代码而非merlin代码” (based on ASUS offical source code instead of merlin code)

Notice the difference between "official"(官方) and "offcial mod"(官方改版 or 官改)and "merlin mod" (梅林改版 or ML改版)
offcial mod firmware only add "software center" to official firmware, so offcial mod firmware can use "type=asuswrt"
merlin and merlin mod firmware can't use "type=asuswrt" to start running the game accelerator

"type=asuswrt" is redirect to a shell script file for official or official mod firmware, not for merlin
so why merlin's author need to fix the offical firmeware shell script ("type=asuswrt") ,instead of use merlin shell script ("type=asuswrt-merlin"), specifically for merlin firmware

If "type=asuswrt" and firmware is official or official mod version:
binary tar file:
https://router.uu.163.com/api/plugin?type=asuswrt-merlin-ac88u or https://router.uu.163.com/api/plugin?type=asuswrt-rtax88u
(https://router.uu.163.com/api/plugin?type=asuswrt-{lowercasemodelwithout-})
monitor file:
https://router.uu.163.com/api/script/monitor?type=asuswrt

If "type=asuswrt-merlin" and firmware is merlin:
binary tar file:
https://router.uu.163.com/api/plugin?type=asuswrt-merlin
monitor file:
https://router.uu.163.com/api/script/monitor?type=asuswrt-merlin

If device is third-party and firmware is merlin:
binary tar file:
https://router.uu.163.com/api/plugin?type=merlin-armv7
https://router.uu.163.com/api/plugin?type=merlin-armv8
https://router.uu.163.com/api/plugin?type=linksys-merlin-ea6400
https://router.uu.163.com/api/plugin?type=netgear-merlin-r6400

base on monitor shell script file from https://router.uu.163.com/api/script/monitor?type=asuswrt
(https://uu.gdl.netease.com/asuswrt/r201910101020/uuplugin_monitor.sh)
https://router.uu.163.com/api/plugin?type=asuswrt-{lowercasemodelwithout-}&sn={mac}
this plugin can't running on merlin firmware without u fix solution

@paldier
Copy link
Contributor

paldier commented Mar 9, 2021

@VirgilClyne
Copy link
Contributor Author

VirgilClyne commented Mar 9, 2021

see my code
https://github.com/MerlinRdev/gtac5300-merlin/blob/fe00643efc04982cfb6b188e1089a9e7d9fa1ab4/release/src/router/www/sysdep/GT-AC5300/www/GameDashboard.asp#L1063
all asus devices should use "asuswrt".
non-asus should use "asuswrt-merlin".

of course, ur firmware based on ASUS official source code instead of merlin code, "asuswrt" Work correctly on ur official mod firmware, but doesn't work on merlin, all ASUS devices with merlin firmware can use "asuswrt-merlin" work correctly, no need to identify the device model

RMerl added a commit that referenced this pull request May 13, 2021
webui: Fix NetEase UU Game Accelerator model type
RMerl added a commit that referenced this pull request May 13, 2021
webui: Fix NetEase UU Game Accelerator model type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants