Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HIPIFY][#178][patch] Add patches for clang 10.0.0, 10.0.1, and 11.0.0 #206

Merged
merged 2 commits into from
Oct 22, 2020

Conversation

emankov
Copy link
Collaborator

@emankov emankov commented Oct 20, 2020

  • Download the patch and unpack it into your LLVM source directory: the file Cuda.cpp will be overwritten; needs further rebuilding of LLVM
  • Update README.md accordingly

The fix will arrive with LLVM 11.0.1 and 12.0.0.

…1.0.0

+ Download the patch and unpack it into your LLVM source directory: the file Cuda.cpp will be overwritten; needs further rebuilding of LLVM.
+ Update README.md accordingly

The fix will arrive with LLVM 11.0.1 and 12.0.0
@emankov emankov added documentation Improvements or additions to documentation fix It fixes bug labels Oct 20, 2020
@emankov emankov self-assigned this Oct 20, 2020
@emankov emankov requested a review from yxsamliu October 20, 2020 19:07
| [9.0.0](http://releases.llvm.org/download.html#9.0.0) , [9.0.1](http://releases.llvm.org/download.html#9.0.1) | [10.1](https://developer.nvidia.com/cuda-10.1-download-archive-base) | + | + |
| [10.0.0](http://releases.llvm.org/download.html#10.0.0) , [10.0.1](https://releases.llvm.org/download.html#10.0.1) | [**11.0**](https://developer.nvidia.com/cuda-11.0-download-archive), [11.0 Update 1](https://developer.nvidia.com/cuda-11.0-update1-download-archive)\*\*\*, [11.1](https://developer.nvidia.com/cuda-downloads)\*\*\* | + | + |
| [**11.0.0**](https://releases.llvm.org/download.html#11.0.0) | [**11.0**](https://developer.nvidia.com/cuda-11.0-download-archive), [11.0 Update 1](https://developer.nvidia.com/cuda-11.0-update1-download-archive)\*\*\*, [11.1](https://developer.nvidia.com/cuda-downloads)\*\*\* | + <br/> **LATEST STABLE RELEASE** | + <br/> **LATEST STABLE RELEASE** |
<table align="center">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It used to be md format but now becomes html. Is this intended?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is intended, cause I was unable to apply HTML's colspan and rowspan analogues in GitHub's Markdown format (|| doesn't work). Nonetheless, GitHub correctly parses Markdown documents with simple HTML injections.
Before (mostly in md format):
before
After (with HTML table injection)
after

@emankov emankov requested a review from yxsamliu October 21, 2020 10:49
[Reason]
CudaVersion::LATEST_SUPPORTED can't be used as it was added in clang 11.0.0
@emankov emankov merged commit 89bcaf7 into ROCm:master Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation fix It fixes bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants