-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for GridSample operator #2909
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2909 +/- ##
===========================================
+ Coverage 91.82% 91.90% +0.08%
===========================================
Files 486 487 +1
Lines 18991 19192 +201
===========================================
+ Hits 17438 17639 +201
Misses 1553 1553 ☔ View full report in Codecov by Sentry. |
This build is OK for merge ✅ |
🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output |
6066406
to
4287616
Compare
e9fbe18
to
dda7a4a
Compare
I had to exclude |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Add cubic support + onnx backend coverage - created issue GridSample cubic/bicubic mode is not supported #2960
- Add additional test cases for coverage
- [ ] Fix loop to pre increment - Look into alternative to avoid O(n^4) updates and ops.
ad8ac0d
to
17205b0
Compare
@TedThemistokleous @pfultz2 I've adressed the majority of you commets except the |
Windows build requires '#include<array>' otherwise we get a compile error when using std:array
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2909 +/- ##
===========================================
+ Coverage 91.97% 92.05% +0.08%
===========================================
Files 489 490 +1
Lines 19398 19599 +201
===========================================
+ Hits 17841 18042 +201
Misses 1557 1557 ☔ View full report in Codecov by Sentry. |
@gyulaz-htec you don't need hit the "update branch" button. Once the review are complete I'll handle it |
I would like to see additional documentation and possible refactoring since the parse_gridsample.cpp is quite large. Not blocking for merge. |
Add support for GridSample onnx operator.
Currently the following feature set is supported:
0
and1
linear
andnearest
zeros
,border
andreflection
Fixes: Accuracy issue with fuse_pointwise and GridSample #2923