Fix conversion of texture addressing mode #2229
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hipAddressModeClamp corresponds to CL_ADDRESS_CLAMP_TO_EDGE. This change fixes incorrect sampling near texture edges.
gandryey
approved these changes
Feb 1, 2021
gargrahul
pushed a commit
that referenced
this pull request
Jul 27, 2021
hipAddressModeClamp corresponds to CL_ADDRESS_CLAMP_TO_EDGE. This change fixes incorrect sampling near texture edges. #2229 Change-Id: Ia2af9f3cb582a74af7b1f65bad1ed0310eab2628
|
Closing all existing pull requests that do not target the develop branch. In case this pull request is still valid, please rebase your changes against develop branch and resubmit. |
hubot
pushed a commit
to blender/blender
that referenced
this pull request
Feb 29, 2024
This was fixed in the driver quite a while ago: ROCm/HIP#2229 Ref: #91571 Pull Request: https://projects.blender.org/blender/blender/pulls/118540
hubot
pushed a commit
to blender/blender
that referenced
this pull request
Mar 12, 2024
This was fixed in the driver quite a while ago: ROCm/HIP#2229 Ref: #91571 Pull Request: https://projects.blender.org/blender/blender/pulls/118540
hubot
pushed a commit
to blender/blender
that referenced
this pull request
Mar 12, 2024
This was fixed in the driver quite a while ago: ROCm/HIP#2229 Ref: #91571 Pull Request: https://projects.blender.org/blender/blender/pulls/118540
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hipAddressModeClampcorresponds toCL_ADDRESS_CLAMP_TO_EDGE.This change fixes incorrect sampling near texture edges.
https://www.khronos.org/registry/OpenCL/sdk/1.2/docs/man/xhtml/sampler_t.html
https://docs.nvidia.com/cuda/cuda-runtime-api/group__CUDART__TYPES.html#group__CUDART__TYPES_1g03e1bbd2c491d809279c7a47e2cd0351