Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HIPIFY][feature] Add a new function call transformation type "additional non-const arg" #837

Closed
emankov opened this issue Apr 13, 2023 · 1 comment
Closed

[HIPIFY][feature] Add a new function call transformation type "additional non-const arg" #837

emankov opened this issue Apr 13, 2023 · 1 comment
Assignees
@emankov
Labels
feature Feature request or implementation

Comments

@emankov
Copy link
Collaborator

emankov commented Apr 13, 2023

The additional arg should be declared before the function call with the specified assigned value or created in case of pointer type.

[Example]
cudnnGetRNNDescriptor_v6 -> miopenGetRNNDescriptor_V2,
where such an additional arg is miopenRNNBiasMode_t *biasMode
@emankov emankov added the feature Feature request or implementation label Apr 13, 2023
@emankov emankov self-assigned this Apr 13, 2023
emankov added a commit to emankov/HIPIFY that referenced this issue Apr 13, 2023
@emankov
[HIPIFY][ROCm#584][DNN][MIOpen] cuDNN -> MIOpen - Part 16 - cuDNN RNN…
d78f299 
… functions - partially

+ Continued supporting hipification to MIOpen based on `miopen.h`
+ Updated the synthetic test `cudnn2miopen.cu` accordingly

[ToDo]
+ [feature][ROCm#837] Add a new function call transformation type "additional non-const arg"
+ Update hipification of function `cudnnGetRNNDescriptor_v6` based on implementation of ROCm#837
@emankov emankov mentioned this issue Apr 13, 2023
Merged
emankov added a commit to emankov/HIPIFY that referenced this issue Apr 16, 2023
@emankov
[HIPIFY][ROCm#584][DNN][MIOpen] cuDNN -> MIOpen - Part 18 - cuDNN CTC…
da7e4fc 
… Loss functions

+ Finished with RNN functions
+ Continued supporting hipification to MIOpen based on `miopen.h`
+ Updated the synthetic test `cudnn2miopen.cu` accordingly

[ToDo]
+ [ROCm#837] for miopenGetRNNDescriptor_V2, miopenSetRNNDescriptor_V2, miopenGetCTCLossDescriptor, and miopenSetCTCLossDescriptor
@emankov emankov mentioned this issue Apr 16, 2023
Merged
emankov added a commit to emankov/HIPIFY that referenced this issue Apr 17, 2023
@emankov
[HIPIFY][ROCm#584][DNN][MIOpen] cuDNN -> MIOpen - Part 19 - cuDNN Dro…
bf8277a 
…pout functions

+ Continued supporting hipification to MIOpen based on `miopen.h`
+ Updated the synthetic test `cudnn2miopen.cu` accordingly

[ToDo]
+ [ROCm#837] for miopenGetDropoutDescriptor, miopenSetDropoutDescriptor, miopenRestoreDropoutDescriptor, miopenDropoutForward, and miopenDropoutBackward
@emankov emankov mentioned this issue Apr 17, 2023
Merged
emankov added a commit to emankov/HIPIFY that referenced this issue Aug 28, 2023
@emankov
[HIPIFY][ROCm#674][ROCm#837][rocSPARSE][feature] rocSPARSE support - …
b4f18fd 
…Step 32 - functions

+ Implemented a new function call transformation type "additional non-const arg" (`e_add_var_argument`)
+ The variable for the adding function argument is a copy of another function call argument
+ The new transformation is tested on rocSPARSE functions `rocsparse_(s|d|c|z)gpsv_interleaved_batch`, where:
  - an additional argument rocsparse_int batch_stride is copied from the previous one: rocsparse_int batch_count;
  - it is how hipsparse(S|D|C|Z)gpsvInterleavedBatch calls rocsparse_(s|d|c|z)gpsv_interleaved_batch in its implementation;
+ Updated synthetic tests and the regenerated hipify-perl and SPARSE docs
emankov added a commit that referenced this issue Aug 28, 2023
@emankov
Merge pull request #1001 from emankov/HIPIFY
64a61cd 
[HIPIFY][#674][#837][rocSPARSE][feature] rocSPARSE support - Step 32 - functions
@emankov
Copy link
Collaborator Author

emankov commented Aug 28, 2023

Implemented by #1001

@emankov emankov closed this as completed Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emankov emankov

Labels
feature Feature request or implementation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@emankov