[HIPIFY][6.0.0][hipBLAS#366] Support for ROCm HIP 6.0.0 - Step 4 - hipblasDatatype_t -> hipDataType
#1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ipblasDatatype_t` -> `hipDataType` [IMP] + In hipBLAS 6.0.0, ROCm/hipBLAS#366 is finally fixed, thus HIPIFY can use `hipDataType` instead of `hipblasDatatype_t` + `hipDataType` can be found in `hip/library_types.h` (also mapped to CUDA's `library_types.h`) + `rocblas_datatype` is left unchanged [TODO] + Revise all the hipBLAS functions which use `hipblasDatatype_t` or `hipDataType` + Remove now the unnecessary option `-use-hip-data-types` + Close ROCm/hipBLAS/issues/366 as implemented with the releasing of hipBLAS 6.0.0 + [long-term] Move `hipDataType` from BLAS to Runtime, when other than hipBLAS libs will start using `hipDataType`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[IMP]
hipblasDatatype_tshould be replaced with HIP'shipDataTypehipBLAS#366 is finally fixed, thus HIPIFY can usehipDataTypeinstead ofhipblasDatatype_thipDataTypecan be found inhip/library_types.h(also mapped to CUDA'slibrary_types.h)rocblas_datatypeis left unchanged[TODO]
hipblasDatatype_torhipDataType-use-hip-data-typeshipblasDatatype_tshould be replaced with HIP'shipDataTypehipBLAS#366 as implemented with the releasing of hipBLAS 6.0.0hipDataTypefrom BLAS to Runtime, when other than hipBLAS libs will start usinghipDataType