[HIPIFY][#674][hipBLAS-#366][workaround] Introduce an option-driven matcher for Data Types substitution #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…driven matcher for Data Types substitution [Synopsis] + `hipSPARSE` already uses the common HIP library type `hipDataType`, whereas `hipBLAS`, `rocBLAS`, and `rocSPARSE` don't + So, it is needed to hipify `cudaDataType` to `hipDataType` in some cases (like for SPARSE-related sources), and to `hipblasDatatype_t`, `rocblas_datatype`, or `rocsparse_datatype` in other cases [Solution] + There is no single solid solution for sources where `cudaDataType_t` is used for both SPARSE and BLAS + [temporary][partial] Introduce the `--use-hip-data-types` option for use `hipDataType` instead of `hipblasDatatype_t` or `rocblas_datatype`; switched off by default + Introduced option-driven matcher `DataTypeSelection` for Data Types substitution + Check the solution on `cusparseCreateSpVec` to `hipsparseCreateSpVec` hipification, where `hipDataType` is used (the synthetic test `cusparse2hipsparse.cu`) [ToDo] + File tickets to `rocBLAS` and `rocSPARSE` similar to ROCm/hipBLAS#366 + Take into account all of the supported `cudaDataType_t` enum members and update the tests + Remove the workaround after all the HIP libs start to use the single `hipDataType`
emankov
added
feature
emankov
added a commit
to emankov/HIPIFY
that referenced
this pull request
May 31, 2023
…ocs missed in the previous PR
emankov
added a commit
that referenced
this pull request
May 31, 2023
[HIPIFY][#895][fix] Regenerated and updated the hipify-perl and docs missed in the previous PR
emankov
added a commit
to emankov/HIPIFY
that referenced
this pull request
Nov 15, 2023
+ [Reason] `cusparseGetStream` appeared in CUDA 8.0 + [fix] Set the missing A-version for `cusparseGetStream` + Updated synthetic `SPARSE` tests and the regenerated `SPARSE` documentation + [TODO][ROCm#899][HIPIFY][ROCm#895][ROCm#383][hipBLAS-ROCm#366][workaround][temporary] Always convert cudaDataType_t to hipDataType under the `--use-hip-data-types` option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Synopsis]
hipSPARSEalready uses the common HIP library typehipDataType, whereashipBLAS,rocBLAS, androcSPARSEdon'tcudaDataTypetohipDataTypein some cases (like for SPARSE-related sources), and tohipblasDatatype_t,rocblas_datatype, orrocsparse_datatypein other cases[Solution]
cudaDataType_tis used for both SPARSE and BLAS--use-hip-data-typesoption for usehipDataTypeinstead ofhipblasDatatype_torrocblas_datatype; switched off by defaultDataTypeSelectionfor Data Types substitutioncusparseCreateSpVectohipsparseCreateSpVechipification, wherehipDataTypeis used (the synthetic testcusparse2hipsparse.cu)[ToDo]
rocBLASandrocSPARSEsimilar to [5.5.X]hipblasDatatype_tshould be replaced with HIP'shipDataTypehipBLAS#366cudaDataType_tenum members and update the testshipDataType