Audio PR - Augmentation support [ Non Silent Region Detection and Slice ] #1324

swetha097 · 2024-04-03T08:03:47Z

Add NonSilentRegion and Slice augmentation support in MIVisionX
NOTE : PR#1323 has to be merged before this PR

…inx (ROCm#1286) Bumps [rocm-docs-core[api_reference]](https://github.com/RadeonOpenCompute/rocm-docs-core) from 0.34.0 to 0.34.2. - [Release notes](https://github.com/RadeonOpenCompute/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v0.34.0...v0.34.2) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [cryptography](https://github.com/pyca/cryptography) from 42.0.0 to 42.0.2. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@42.0.0...42.0.2) --- updated-dependencies: - dependency-name: cryptography dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

This reverts commit d53f81d.

…he rocAL - since the src and dst rois remain same

amd_openvx_extensions/amd_rpp/include/internal_rpp.h

amd_openvx_extensions/amd_rpp/source/kernel_rpp.cpp

amd_openvx_extensions/amd_rpp/source/tensor/NonSilentRegionDetection.cpp

amd_openvx_extensions/amd_rpp/source/tensor/Slice.cpp

amd_openvx_extensions/amd_rpp/source/kernel_rpp.cpp

rrawther

please address the review comments

…sionX into swbs_m6/audio/pr9

swetha097 · 2024-06-03T16:48:37Z

please address the review comments

Addressed the review comments

LakshmiKumar23

@swetha097 why was the exit label added back?

…ute-Libraries/MIVisionX into swbs_m6/audio/pr9

swetha097 · 2024-06-03T17:30:37Z

@swetha097 why was the exit label added back?

@LakshmiKumar23 The exit label seems to be present in internal_rpp.h file for error check, if removed in the Slice.cpp / NSR.cpp, it leads to build err

error: label ‘exit’ used but not defined
53 | #define PARAM_ERROR_CHECK(call){vx_status status = call; if(status!= VX_SUCCESS) goto exit;}

…sionX into swbs_m6/audio/pr9

dependabot bot and others added 30 commits February 16, 2024 11:18

Merge branch 'develop' of https://github.com/ROCm/MIVisionX into develop

cf47a7f

Add PreEmphasis filter support

f196208

Fix ROI - change from xy to width & height

1e89c02

Adding openvx changes for downmix node

d53f81d

Audio Augmentations 1 PR - NSR and Spectrogram

9cef1ab

Revert "Adding openvx changes for downmix node"

43dbde3

This reverts commit d53f81d.

Merging swbs_m2/audio/pr5 into swbs_m3/audio/pr6

ba6ff14

Fixing build issues

e94c53f

Adding openvx extensions for to_decibels and normalize augmentations

e63809c

Commenting out normalize kernel

589c823

Adding openvx extensions for resample and operator overloading nodes

7f77d64

PR comments resolution in the PreEmphais Filter

b19a9ad

Minor Changes

e92ffe4

Change the borderType enum to int32 from uint32 dtype

b94144c

Fix validation of preemphasis

5808d6b

Remove the memcopy of the src and dest rois as it can be handled in t…

33eb1ce

…he rocAL - since the src and dst rois remain same

Formatting change - minor

8c4a98e

Remove NSR

a58818e

Merge branch 'swbs_m1/audio/pr3' into swbs_m2/audio/pr5

e76b212

Minor formatting changes

c6dcd6b

Minor fix

4e3654a

Merge branch 'swbs_m2/audio/pr5' into swbs_m3/audio/pr6

4495d5c

Merge branch 'swbs_m2/audio/pr5' into swbs_m3/audio/pr6

247cf70

Minor update - remove the 2nd instance of preemphasis filter

e197789

Add openvx extensions for to_decibels augmentations

1a51fee

Enum dtype - change from uint to int

dba24ba

Remove roi_tensor_ptr_dst as its unused after latest changes

6615b27

Remove the dst_roi arg from vxExtRppPreemphasisFilter call as its unused

84100bd

LakshmiKumar23 reviewed May 30, 2024

View reviewed changes

amd_openvx_extensions/amd_rpp/include/internal_rpp.h Show resolved Hide resolved

LakshmiKumar23 reviewed May 30, 2024

View reviewed changes

amd_openvx_extensions/amd_rpp/source/kernel_rpp.cpp Outdated Show resolved Hide resolved

rrawther reviewed May 30, 2024

View reviewed changes

amd_openvx_extensions/amd_rpp/source/tensor/NonSilentRegionDetection.cpp Show resolved Hide resolved

LakshmiKumar23 reviewed May 30, 2024

View reviewed changes

amd_openvx_extensions/amd_rpp/source/tensor/Slice.cpp Outdated Show resolved Hide resolved

rrawther reviewed May 30, 2024

View reviewed changes

amd_openvx_extensions/amd_rpp/source/tensor/Slice.cpp Show resolved Hide resolved

rrawther reviewed May 30, 2024

View reviewed changes

amd_openvx_extensions/amd_rpp/source/tensor/Slice.cpp Show resolved Hide resolved

rrawther reviewed May 30, 2024

View reviewed changes

amd_openvx_extensions/amd_rpp/source/kernel_rpp.cpp Show resolved Hide resolved

rrawther requested changes May 30, 2024

View reviewed changes

LakshmiKumar23 and others added 8 commits June 3, 2024 09:07

Merge branch 'develop' into swbs_m6/audio/pr9

b0d90f6

Merge remote-tracking branch 'upstream/develop' into swbs_m6/audio/pr9

bb0dc29

Merge branch 'swbs_m6/audio/pr9' of https://github.com/swetha097/MIVi…

428913d

…sionX into swbs_m6/audio/pr9

Add audio flag for slice

c1434c8

Merge branch 'swbs_m6/audio/pr9' of https://github.com/swetha097/MIVi…

ae2d74d

…sionX into swbs_m6/audio/pr9

Remove the exit label

72704fd

Merge branch 'swbs_m6/audio/pr9' of https://github.com/swetha097/MIVi…

7b2062d

…sionX into swbs_m6/audio/pr9

Modify the redundant lines of fillGenericDescPtrFromDims

d9e4045

Ad the label exit back

3e666cb

LakshmiKumar23 approved these changes Jun 3, 2024

View reviewed changes

LakshmiKumar23 requested changes Jun 3, 2024

View reviewed changes

LakshmiKumar23 approved these changes Jun 3, 2024

View reviewed changes

Merge branch 'develop' of https://github.com/GPUOpen-ProfessionalComp…

99b30fb

…ute-Libraries/MIVisionX into swbs_m6/audio/pr9

swetha097 and others added 5 commits June 3, 2024 17:33

Make the right Copyright change reverted in previous commit

6f811f3

Merge branch 'swbs_m6/audio/pr9' of https://github.com/swetha097/MIVi…

f12ca98

…sionX into swbs_m6/audio/pr9

Add audio flag for slice

655463f

Merge branch 'swbs_m6/audio/pr9' of https://github.com/swetha097/MIVi…

f32635a

…sionX into swbs_m6/audio/pr9

Merge branch 'develop' into swbs_m6/audio/pr9

d7cefcd

rrawther approved these changes Jun 4, 2024

View reviewed changes

kiritigowda merged commit c3ee51c into ROCm:develop Jun 4, 2024
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Audio PR - Augmentation support [ Non Silent Region Detection and Slice ] #1324

Audio PR - Augmentation support [ Non Silent Region Detection and Slice ] #1324

swetha097 commented Apr 3, 2024 •

edited

rrawther left a comment

swetha097 commented Jun 3, 2024

LakshmiKumar23 left a comment

swetha097 commented Jun 3, 2024 •

edited

Audio PR - Augmentation support [ Non Silent Region Detection and Slice ] #1324

Audio PR - Augmentation support [ Non Silent Region Detection and Slice ] #1324

Conversation

swetha097 commented Apr 3, 2024 • edited

rrawther left a comment

Choose a reason for hiding this comment

swetha097 commented Jun 3, 2024

LakshmiKumar23 left a comment

Choose a reason for hiding this comment

swetha097 commented Jun 3, 2024 • edited

swetha097 commented Apr 3, 2024 •

edited

swetha097 commented Jun 3, 2024 •

edited