New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't build on musl systems #65
Comments
Excuse my ignorance. What's a musl system? If there is a conflict between our global variable PAGE_SIZE and a macro defined in a header file, it may be cleaner to rename our variable to something like g_page_size. |
musl is an alternative to glibc: https://musl.libc.org/ I don't know much about C and especially not these kind of global variables, that's why I made this an issue instead of PR. Some more info about PAGE_SIZE in musl: |
Do you perhaps have a fix for 5.6? Unfortunately I am getting errors on my system |
PAGE_SIZE is a reserved symbolic name of <limits.h>[1], so it is not an issue that can be fixed on musl side. There is an open bug in Gentoo[2] on ROCT-Thunk-Interface (one of multiple). [1] https://pubs.opengroup.org/onlinepubs/7908799/xsh/limits.h.html |
This allows to build ROCT-Thunk-Interface for Alpine Linux, Gentoo with musl profile and so on. List of changes: * Fix redefinition of PAGE_SIZE from limits.h * Use NAME_MAX from limits.h Closes ROCm#65 Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
…d 6.0.0 Upstream PR: ROCm/ROCT-Thunk-Interface#96 Upstream bug: ROCm/ROCT-Thunk-Interface#65 Closes: https://bugs.gentoo.org/830944 Closes: https://bugs.gentoo.org/715434 Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
…d 6.0.0 Upstream PR: ROCm/ROCT-Thunk-Interface#96 Upstream bug: ROCm/ROCT-Thunk-Interface#65 Closes: https://bugs.gentoo.org/830944 Closes: https://bugs.gentoo.org/715434 Signed-off-by: Sv. Lockal <lockalsash@gmail.com> Signed-off-by: Sam James <sam@gentoo.org>
the following patch fixes this:
The text was updated successfully, but these errors were encountered: