Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Almost completely re-written to build images with docker-compose #95

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

aimoff
Copy link

@aimoff aimoff commented Sep 11, 2022

  • All images are built with docker-compose.
  • Reuse pre-built image to reduce time and space.
  • Re-wrote docker-compose.yml
    • Remove (probably) obsolete services for building images from souce.
    • Only a specific OS version is teated at a time.
      • OS / version / variant are specified by .env file.
  • render group id is set to same number as host.
  • Use gpg --dearmor instead of apt-key add for ubuntu-20.04.

* All images are built with docker-compose.
* Reuse pre-built image to reduce time and space.
* Re-wrote `docker-compose.yml`
  * Remove (probably) obsolete services for building images from souce.
  * Only a specific OS version is teated at a time.
    * OS / version / variant are specified by `.env` file.
* `render` group id is set to same number as host.
* Use `gpg --dearmor` instead of `apt-key add` for ubuntu-20.04.
@aimoff
Copy link
Author

aimoff commented Sep 11, 2022

Need documents update if this patch will be applied.
I modified README.md for explanation of this patch, but it is not suitable for release.

* Add image variants based on newer ROCm meta-packages
* Omit CentOS-7 stuff
* Add Ubuntu 22.04 stuffs.
  * Add `/etc/apt/preferences.d/90-rocm-jammy` to give higer priority
    to ROCm packages, since Ubuntu 22.04 already has ROCm related
    packages on universe archive.
* Change url for ROCm packages.
@aimoff
Copy link
Author

aimoff commented Oct 3, 2022

I updated my git tree:

Remove DBUS_SESSION_BUS_ADDRESS environment from docker-compose.yaml
Update default to ROCm 5.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant