Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Precision support #2815

Merged
merged 9 commits into from
Mar 5, 2024
Merged

Precision support #2815

merged 9 commits into from
Mar 5, 2024

Conversation

neon60
Copy link
Collaborator

@neon60 neon60 commented Jan 17, 2024

No description provided.

@saadrahim
Copy link
Member

Please make CI pass.

@neon60 neon60 requested a review from a team as a code owner January 31, 2024 10:13
@neon60 neon60 force-pushed the precision_support branch 5 times, most recently from a2f7d2a to b399869 Compare February 1, 2024 13:38
@neon60 neon60 changed the title WIP - Precision support Precision support Feb 2, 2024
MKKnorr
MKKnorr reviewed Feb 7, 2024
View reviewed changes
docs/about/compatibility/precission-support.md Outdated Show resolved Hide resolved
docs/about/compatibility/precission-support.md Outdated Show resolved Hide resolved
docs/about/compatibility/precission-support.md Outdated Show resolved Hide resolved
docs/about/compatibility/precission-support.md Outdated Show resolved Hide resolved
docs/about/compatibility/precission-support.md Outdated Show resolved Hide resolved
docs/about/compatibility/precission-support.md Outdated Show resolved Hide resolved
docs/about/compatibility/precission-support.md Outdated Show resolved Hide resolved
docs/about/compatibility/precission-support.md Outdated Show resolved Hide resolved
docs/about/compatibility/precission-support.md Outdated Show resolved Hide resolved
docs/about/compatibility/precission-support.md Outdated Show resolved Hide resolved
@MKKnorr
Copy link
Contributor

MKKnorr commented Feb 7, 2024

Also please fix the spellchecker/add to the wordlist :)

@neon60 neon60 force-pushed the precision_support branch 5 times, most recently from 30773a2 to e14ed06 Compare February 13, 2024 13:43
MKKnorr
MKKnorr reviewed Feb 13, 2024
View reviewed changes
docs/about/compatibility/precission-support.rst Outdated Show resolved Hide resolved
docs/about/compatibility/precission-support.rst Outdated Show resolved Hide resolved
docs/about/compatibility/precission-support.rst Outdated Show resolved Hide resolved
docs/about/compatibility/precission-support.rst Outdated Show resolved Hide resolved
docs/about/compatibility/precission-support.rst Outdated Show resolved Hide resolved
docs/about/compatibility/precission-support.rst Outdated Show resolved Hide resolved
docs/about/compatibility/precission-support.rst Outdated Show resolved Hide resolved
docs/about/compatibility/precission-support.rst Outdated Show resolved Hide resolved
docs/about/compatibility/precission-support.rst Outdated Show resolved Hide resolved
docs/sphinx/_toc.yml.in Outdated Show resolved Hide resolved
@neon60 neon60 requested a review from MKKnorr February 13, 2024 16:15
MKKnorr
MKKnorr previously approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@MKKnorr MKKnorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job :)

@neon60
Copy link
Collaborator Author

neon60 commented Feb 13, 2024 •
edited

@Rmalavally Can you review this, please? You already checked few of our data support pages. This is the main landing page, where you can access the detailed data type support pages of the projects.

We would like to extend the list of libraries, when we checked a library already.

@Rmalavally
Copy link
Collaborator

@Rmalavally Can you review this, please? You already checked few of our data support pages. This is the main landing page, where you can access the detailed data type support pages of the projects.

We would like to extend the list of libraries, when we checked a library already.

Nicely done. Thanks for your efforts @neon60 . We could consider further enhancing the descriptions in subsequent releases.

One minor edit - I think the file name is spelt 'precission-support.md', and there are few other instances of this typo. Could you please correct it to 'precision'? Thanks so much.

@neon60
Copy link
Collaborator Author

neon60 commented Feb 13, 2024 •
edited

@Rmalavally Can you review this, please? You already checked few of our data support pages. This is the main landing page, where you can access the detailed data type support pages of the projects.
We would like to extend the list of libraries, when we checked a library already.

Nicely done. Thanks for your efforts @neon60 . We could consider further enhancing the descriptions in subsequent releases.

One minor edit - I think the file name is spelt 'precission-support.md', and there are few other instances of this typo. Could you please correct it to 'precision'? Thanks so much.

Fixed. Thanks.

MKKnorr
MKKnorr previously approved these changes Feb 14, 2024
View reviewed changes
@neon60 neon60 requested a review from parbenc February 14, 2024 09:56
parbenc
parbenc reviewed Feb 14, 2024
View reviewed changes
Copy link
Contributor

@parbenc parbenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have a minor question. otherwise looks good

docs/about/compatibility/data-type-support.rst Outdated Show resolved Hide resolved
@neon60 neon60 force-pushed the precision_support branch 3 times, most recently from 3ba9f20 to 353165e Compare February 26, 2024 09:36
MKKnorr
MKKnorr previously requested changes Feb 29, 2024
View reviewed changes
docs/about/compatibility/data-type-support.rst Outdated Show resolved Hide resolved
docs/about/compatibility/data-type-support.rst Outdated Show resolved Hide resolved
docs/about/compatibility/data-type-support.rst Outdated Show resolved Hide resolved
docs/about/compatibility/data-type-support.rst Outdated Show resolved Hide resolved
docs/about/compatibility/data-type-support.rst Outdated Show resolved Hide resolved
docs/about/compatibility/data-type-support.rst Outdated Show resolved Hide resolved
docs/about/compatibility/data-type-support.rst Outdated Show resolved Hide resolved
docs/about/compatibility/data-type-support.rst Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/sphinx/_toc.yml.in Outdated Show resolved Hide resolved
@neon60 neon60 requested a review from MKKnorr February 29, 2024 10:13
@neon60 neon60 requested a review from MKKnorr February 29, 2024 12:17
@saadrahim saadrahim dismissed MKKnorr’s stale review February 29, 2024 22:06

I believe the review is old

neon60 and others added 9 commits March 4, 2024 18:18
@neon60
Precision support page initial commit
1872f09 
Move to rst file

Fix details of Mi100

Update docs/about/compatibility/precission-support.md Co-authored-by: MKKnorr <MKKnorr@web.de>
@neon60 @MKKnorr
Update precission-support page
ccadc50 
Co-authored-by: MKKnorr <MKKnorr@web.de>
@neon60
PR fix based on feedbackcs
2fe6800
@neon60
Rename precision-support.rst to data-type_support.rts
4368bbc
@neon60
Update rocThrust library data type support
afab46e
@neon60
PR findings fixes
dde1f8b
@neon60 @MKKnorr
Update data-type-support page
2138d3c 
Co-authored-by: MKKnorr <MKKnorr@web.de>
@neon60 @MKKnorr
Update docs/about/compatibility/data-type-support.rst
00066a9 
Co-authored-by: MKKnorr <MKKnorr@web.de>
@neon60
lisa edits
5fa20a4
@saadrahim saadrahim merged commit 47d06cb into develop Mar 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parbenc parbenc parbenc left review comments

@saadrahim saadrahim saadrahim approved these changes

@Rmalavally Rmalavally Awaiting requested review from Rmalavally

@amd-aakash amd-aakash Awaiting requested review from amd-aakash amd-aakash is a code owner

@zhang2amd zhang2amd Awaiting requested review from zhang2amd

@jlgreathouse jlgreathouse Awaiting requested review from jlgreathouse jlgreathouse is a code owner

@samjwu samjwu Awaiting requested review from samjwu samjwu is a code owner

@MathiasMagnus MathiasMagnus Awaiting requested review from MathiasMagnus

@LisaDelaney LisaDelaney Awaiting requested review from LisaDelaney

@MKKnorr MKKnorr Awaiting requested review from MKKnorr

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@neon60 @saadrahim @MKKnorr @Rmalavally @parbenc