Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update code snippet in Model Quantization guide #3281

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Update code snippet in Model Quantization guide #3281

merged 1 commit into from
Jun 12, 2024

Conversation

peterjunpark
Copy link
Contributor

No description provided.

yhuiYH
yhuiYH approved these changes Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@yhuiYH yhuiYH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Here's an approval to unblock you, but good to get approval from who provided you the content.

@peterjunpark peterjunpark merged commit d24b3fa into ROCm:develop Jun 12, 2024
3 checks passed
AlexHe99
AlexHe99 reviewed Jun 13, 2024
View reviewed changes
Copy link

@AlexHe99 AlexHe99 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexHe99 AlexHe99 AlexHe99 left review comments

@yhuiYH yhuiYH yhuiYH approved these changes

@amd-aakash amd-aakash Awaiting requested review from amd-aakash amd-aakash is a code owner

@jlgreathouse jlgreathouse Awaiting requested review from jlgreathouse jlgreathouse is a code owner

@samjwu samjwu Awaiting requested review from samjwu samjwu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peterjunpark @yhuiYH @AlexHe99