Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests failing with "AssertionError: If capturable=False, state_steps should not be CUDA tensors." #82

Closed
jithunnair-amd opened this issue Aug 5, 2022 · 1 comment
Closed

Unit tests failing with "AssertionError: If capturable=False, state_steps should not be CUDA tensors." #82

jithunnair-amd opened this issue Aug 5, 2022 · 1 comment
Assignees
@hubertlu-tw

Comments

@jithunnair-amd
Copy link
Collaborator

jithunnair-amd commented Aug 5, 2022 •
edited by hubertlu-tw

test_adam_option (test_fused_optimizer.TestFusedAdam): due to pytorch/pytorch#80809 (comment)
test_multi_device (test_fused_optimizer.TestFusedAdam): due to pytorch/pytorch#80809 (comment)
test_float (test_fused_optimizer.TestFusedAdam): due to pytorch/pytorch#80809 (comment)
test_bfloat16 (test_fused_optimizer.TestFusedAdam): due to pytorch/pytorch#80809 (comment)

Reference: #78 (comment)
@jithunnair-amd jithunnair-amd mentioned this issue Aug 5, 2022
Merged
@hubertlu-tw
Copy link

The tests failed due to a regression introduced from PyTorch upstream: pytorch/pytorch#80809 (comment). They can be unskipped once the fix is integrated into PyTorch ROCm fork from PyTorch upstream.

@hubertlu-tw hubertlu-tw mentioned this issue Aug 10, 2022
Merged
hubertlu-tw pushed a commit that referenced this issue Nov 14, 2022
Unskip some unit tests related to issue #82
501b6fe
@hubertlu-tw hubertlu-tw mentioned this issue Nov 14, 2022
Merged
jithunnair-amd pushed a commit that referenced this issue Dec 6, 2022
@hubertlu-tw
Unskip some unit tests related to issue #82 (#98)
4dcf30a 
* Unskip some unit tests related to issue #82

* Ensure test_state_dict to use capturable=True for torch.optim.Adam

* Fix TestFusedAdam tests in test_fused_optimizer.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hubertlu-tw hubertlu-tw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jithunnair-amd @hubertlu-tw