Skip to content

Commit

Permalink
SWDEV-443109 - Fix for CXX compiler check in hip-config-amd.cmake
Browse files Browse the repository at this point in the history
Change-Id: Ib6b8bc59a889ad2e4f440e847d9f2e7e8fb2cda2
  • Loading branch information
iassiour committed Jan 26, 2024
1 parent be486ca commit b60926a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion hipamd/hip-config-amd.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ foreach(GPU_TARGET ${GPU_TARGETS})
hip_add_interface_link_flags(hip::device --offload-arch=${GPU_TARGET})
endforeach()
#Add support for parallel build and link
if(${CMAKE_CXX_COMPILER_ID} STREQUAL "Clang")
if("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang")

This comment has been minimized.

Copy link
@ye-luo

ye-luo Jan 26, 2024

FYI. You may also just do if(CMAKE_CXX_COMPILER_ID STREQUAL "Clang")

if(<variable|string> STREQUAL <variable|string>)

A quoted string as you did or just the variable

check_cxx_compiler_flag("-parallel-jobs=1" HIP_CLANG_SUPPORTS_PARALLEL_JOBS)
endif()
if(HIP_CLANG_NUM_PARALLEL_JOBS GREATER 1)
Expand Down

0 comments on commit b60926a

Please sign in to comment.