Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The calls to currentStackInfo cause issues if a library uses stackful coroutines #36

Open
gbaraldi opened this issue Nov 24, 2023 · 1 comment

Comments

@gbaraldi
Copy link

So the context here is JuliaGPU/AMDGPU.jl#549 where julia switches the thread stack in to have goroutine like tasks. But that causes some issues, specifically in the call to https://github.com/ROCm-Developer-Tools/clr/blob/1a0c3e4dc45237716c08a6b74be5ff6405422ead/rocclr/os/os_posix.cpp#L290-L312 from https://github.com/ROCm-Developer-Tools/clr/blob/d96481fb3609720058180ca5aa02b1da57df68a5/rocclr/thread/thread.cpp#L32-L36 .
Taking a quick look, it doesn't seem that the stackBase_ and stackSize_ fields are used anywhere in the library, so I was curious if they have any use, or if they could be removed in order to avoid issues like these

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants