Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hipify runtime API #50

Merged
merged 12 commits into from
Apr 16, 2024
Merged

Hipify runtime API #50

merged 12 commits into from
Apr 16, 2024

Conversation

pnunna93
Copy link

This PR has changes for hipifying runtime library.

  • Enabled runtime_hip in features file
  • Updated pyx, pxd and header files for hipification and missing API
  • Fixed error with MemoryType attribute setting for pointerGetAttributes function
  • Fixed cimport error with runtime_hip
  • Added new custom mapping from CUPY_DONT_USE_GEN_HIP_CODE to CUPY_USE_GEN_HIP_CODE for api declaration in pxd file
  • Updated enum declarations for runtime (Instead of using hipified enum file, this PR adds hipified enums in cuda file)

@pnunna93
Copy link
Author

UT log on ROCm 6.1:
cupy_runtime_hipify_rocm6.1.log

Copy link

@AdrianAbeyta AdrianAbeyta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@lcskrishna lcskrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lcskrishna lcskrishna merged commit 9251fd2 into rocm6.2_internal_testing Apr 16, 2024
9 checks passed
@pnunna93 pnunna93 deleted the hipify_runtime branch April 16, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants