Adding missing L1 functions #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amcamd
approved these changes
Oct 18, 2019
| HIPBLAS_EXPORT hipblasStatus_t | ||
| hipBlasDznrm2(hipblasHandle_t handle, int n, const hipDoubleComplex* x, int incx, double* result); | ||
| */ | ||
|
|
There was a problem hiding this comment.
Can you change to consistent commenting, I think it is best to use the C++ style // everywhere rather than a mix of // and the C style /* and */ .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding (real precision) L1 functions:
iamin is not currently tested as it is still broken in rocBLAS 2.9. Rotation functions (rot(m)(g)) not in rocBLAS 2.9, so not being supported right now. Complex functionality coming in a future PR as well.