Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add node_selector_enabled variable #58

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

rptaylor
Copy link
Contributor

This is an alternative to #29 @y2kenny

Default behaviour before: there would be no nodeselectors applied because nfd.enabled is false by default. If you set nfd.enabled=true, then you would get both an installation of NFD, and application of nodeselectors on the daemonsets.

Default behaviour after: there would be no nodeselectors applied because node_selector_enabled is false by default. Installation of NFD and application of nodeselectors can be controlled separately and independently.

Anyone who previously set nfd.enabled=true and got both a NFD installation and nodeselectors will now need to also set node_selector_enabled=true to continue applying the same nodeselector as before.

It's a bit weird but seems like a less disruptive way to un-overload the nfd.enabled variable.

@rptaylor
Copy link
Contributor Author

Partially related to #19

@julian3xl @boniek83 have a look if you're still interested.

@y2kenny-amd y2kenny-amd merged commit 73d8618 into ROCm:master Apr 17, 2024
@rptaylor rptaylor deleted the 20240411-nodeselector-condition branch April 17, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants