Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernelNames dropdown is unreadable #102

Closed
coleramos425 opened this issue Mar 22, 2023 · 2 comments
Closed

kernelNames dropdown is unreadable #102

coleramos425 opened this issue Mar 22, 2023 · 2 comments
Assignees
Labels
bug Something isn't working Standalone GUI Related to Omniperf's standalone GUI

Comments

@coleramos425
Copy link
Collaborator

When analyzing a workload in the Flask GUI with very long kernelNames the dropdown filter becomes unreadable. You'll notice text will overlap and it's nearly impossible for the user to work with.

Please fix this menu to account for applications with these longer kernelNames.
image

@coleramos425 coleramos425 added bug Something isn't working Standalone GUI Related to Omniperf's standalone GUI labels Mar 22, 2023
@coleramos425 coleramos425 added this to the v1.0.8 milestone Mar 22, 2023
@coleramos425 coleramos425 self-assigned this Mar 22, 2023
@coleramos425
Copy link
Collaborator Author

coleramos425 commented Mar 22, 2023

  • Increased row size in the dropdown to improve readability.
  • I also added a span tag to these elements such that hovering over a menu entry will present full kernelName.

image

@jrmadsen
Copy link

@JoseSantosAMD take a look at these modifications and consider applying them to the causal profiling GUI for omnitrace. I got rid of the basename everywhere bc you ended up with two identical names when two files with the same name but in different directories were added -- so now if you pass the absolute path, the top menu starts to look like this

coleramos425 added a commit that referenced this issue Mar 23, 2023
Signed-off-by: coleramos425 <colramos@amd.com>
feizheng10 pushed a commit to feizheng10/omniperf that referenced this issue Dec 6, 2023
Signed-off-by: coleramos425 <colramos@amd.com>
Signed-off-by: fei.zheng <fei.zheng@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Standalone GUI Related to Omniperf's standalone GUI
Projects
None yet
Development

No branches or pull requests

2 participants