Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLES15-SP4 Support #109

Closed
coleramos425 opened this issue Apr 10, 2023 · 1 comment
Closed

SLES15-SP4 Support #109

coleramos425 opened this issue Apr 10, 2023 · 1 comment
Assignees
@coleramos425
Labels
enhancement New feature or request packaging Roofline Related to Omniperf's Roofline Analysis

Comments

@coleramos425
Copy link
Collaborator

Add support for SLES15-SP4. There'll need to be some changes to add this in dectect_roofline()
https://github.com/AMDResearch/omniperf/blob/9770396fa8d75e2d72ead30890cb9d232ff6ea4a/src/omniperf#L273-L290

In addition, modify the automatic build process that we use to create these roofline binaries. We may need to eventually create a test pipeline for this as well.
@coleramos425 coleramos425 added enhancement New feature or request packaging Roofline Related to Omniperf's Roofline Analysis labels Apr 10, 2023
@coleramos425 coleramos425 self-assigned this Apr 10, 2023
@coleramos425 coleramos425 added this to the v1.0.8 milestone Apr 10, 2023
coleramos425 added a commit that referenced this issue Apr 14, 2023
@coleramos425
Roofline support for SLES15 SP3 and greater (#109)
77559a2 
Signed-off-by: coleramos425 <colramos@amd.com>
@coleramos425
Copy link
Collaborator Author

Patch has been applied to the dev branch. Now I just need to do some testing to verify BW output from SP3 binary are still giving expected output on SP4.

feizheng10 pushed a commit to feizheng10/omniperf that referenced this issue Dec 6, 2023
@coleramos425
Roofline support for SLES15 SP3 and greater (ROCm#109)
10e7704 
Signed-off-by: coleramos425 <colramos@amd.com>
Signed-off-by: fei.zheng <fei.zheng@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coleramos425 coleramos425

Labels
enhancement New feature or request packaging Roofline Related to Omniperf's Roofline Analysis
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@coleramos425