Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable CLI Analysis on Windows #110

Closed
coleramos425 opened this issue Apr 11, 2023 · 2 comments
Closed

Enable CLI Analysis on Windows #110

coleramos425 opened this issue Apr 11, 2023 · 2 comments
Assignees
@coleramos425
Labels
enhancement New feature or request

Comments

@coleramos425
Copy link
Collaborator

Will have to look at this closer, but enabling analysis via CLI on Windows may be possible with a few adjustments to shell commands.

Start by inspecting subprocess calls using which
https://github.com/AMDResearch/omniperf/blob/9770396fa8d75e2d72ead30890cb9d232ff6ea4a/src/parser.py#L123-L125
@coleramos425 coleramos425 added the enhancement New feature or request label Apr 11, 2023
@coleramos425 coleramos425 added this to the v1.0.8 milestone Apr 11, 2023
@coleramos425 coleramos425 self-assigned this Apr 11, 2023
@jrmadsen
Copy link

Use shutil.which(...)

@coleramos425
Copy link
Collaborator Author

Implemented in dev branch

coleramos425 added a commit that referenced this issue Apr 18, 2023
@coleramos425
Replace subprocess with shutil (#110)
c794fb8 
Signed-off-by: coleramos425 <colramos@amd.com>
feizheng10 pushed a commit to feizheng10/omniperf that referenced this issue Dec 6, 2023
@coleramos425
Replace subprocess with shutil (ROCm#110)
80cb646 
Signed-off-by: coleramos425 <colramos@amd.com>
Signed-off-by: fei.zheng <fei.zheng@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coleramos425 coleramos425

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jrmadsen @coleramos425