Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The kernel filtering example should give some level of detail on how the filter is used #136

Closed
skyreflectedinmirrors opened this issue Jun 6, 2023 · 1 comment
Closed

The kernel filtering example should give some level of detail on how the filter is used #136

skyreflectedinmirrors opened this issue Jun 6, 2023 · 1 comment
Assignees
@coleramos425
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Milestone
v.1.0.9

Comments

@skyreflectedinmirrors
Copy link
Contributor

https://github.com/AMDResearch/omniperf/blob/a346db7646b0a935f4cac51d131b4a585f065c05/src/docs/profiling.md?plain=1#L283

Currently we just say "it's compatible with rocprof". It would be more accurate (to my understanding) to say that it is a regular expression that used to match against the demangled kernel name.
@coleramos425 coleramos425 added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 8, 2023
@coleramos425 coleramos425 self-assigned this Jun 21, 2023
@coleramos425 coleramos425 added this to the v.1.1.0 milestone Jun 21, 2023
coleramos425 added a commit that referenced this issue Aug 11, 2023
@coleramos425
Updating docs for filtering with examples (#136) (#137)
2699460 
Signed-off-by: coleramos425 <colramos@amd.com>
@coleramos425
Copy link
Collaborator

Done. Revisiting that section, it's clear more specificity was needed. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coleramos425 coleramos425

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
v.1.0.9
Development

No branches or pull requests
2 participants
@skyreflectedinmirrors @coleramos425