Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent rocprof run order #304

Closed
coleramos425 opened this issue Mar 6, 2024 · 0 comments
Closed

Consistent rocprof run order #304

coleramos425 opened this issue Mar 6, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@coleramos425
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
For consistency sake, let's sort rocprof input files before looping execution.

glob.glob order isn't guaranteed to always be the same
https://stackoverflow.com/questions/74451703/glob-glob-returns-same-order-in-each-iteration

Additional context
See example below:

Run 1

Profiler choice = rocprofv1
omniperf ver: 2.0.0-Tech-Preview
Path: /home1/karl/repos/omniperf/sample/workloads/atest/MI100
Target: MI100
Command: ./vcopy -n 1048576 -b 256
Kernel Selection: None
Dispatch Selection: None
IP Blocks: All
KernelName verbose: 2
Current input file: /home1/karl/repos/omniperf/sample/workloads/atest/MI100/perfmon/pmc_perf_3.txt
RPL: on '240306_140053' from '/opt/rocm-6.0.2' in '/home1/karl/repos/omniperf/sample'
RPL: profiling '""./vcopy -n 1048576 -b 256""'
RPL: input file '/home1/karl/repos/omniperf/sample/workloads/atest/MI100/perfmon/pmc_perf_3.txt'
RPL: output dir '/tmp/rpl_data_240306_140053_220340'
RPL: result dir '/tmp/rpl_data_240306_140053_220340/input0_results_240306_140053'
ROCProfiler: input from "/tmp/rpl_data_240306_140053_220340/input0.xml"
  gpu_index = 
  kernel = 
  range = 
  23 metrics

Run 2

Profiler choice = rocprofv1
omniperf ver: 2.0.0-Tech-Preview
Path: /home1/karl/repos/omniperf/sample/workloads/atest/MI100
Target: MI100
Command: ./vcopy -n 1048576 -b 256
Kernel Selection: None
Dispatch Selection: None
IP Blocks: All
KernelName verbose: 2
Current input file: /home1/karl/repos/omniperf/sample/workloads/atest/MI100/perfmon/pmc_perf_4.txt
RPL: on '240306_140118' from '/opt/rocm-6.0.2' in '/home1/karl/repos/omniperf/sample'
RPL: profiling '""./vcopy -n 1048576 -b 256""'
RPL: input file '/home1/karl/repos/omniperf/sample/workloads/atest/MI100/perfmon/pmc_perf_4.txt'
RPL: output dir '/tmp/rpl_data_240306_140118_224797'
RPL: result dir '/tmp/rpl_data_240306_140118_224797/input0_results_240306_140118'
ROCProfiler: input from "/tmp/rpl_data_240306_140118_224797/input0.xml"
  gpu_index = 
  kernel = 
  range = 
  22 metrics

CC: @koomie

@coleramos425 coleramos425 added the enhancement New feature or request label Mar 6, 2024
coleramos425 added a commit that referenced this issue Mar 6, 2024
Signed-off-by: colramos-amd <colramos@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant