Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dead link to grafana in getting started #33

Closed
skyreflectedinmirrors opened this issue Nov 16, 2022 · 2 comments
Closed

Dead link to grafana in getting started #33

skyreflectedinmirrors opened this issue Nov 16, 2022 · 2 comments
Assignees
@koomie
Labels
documentation Improvements or additions to documentation

Comments

@skyreflectedinmirrors
Copy link
Contributor

https://github.com/AMDResearch/omniperf/blob/5fa2dd99bc0d4491750d9287ca6e854bf5fe7770/src/docs/getting_started.md?plain=1#L72

Now that grafana-analysis has it's own page, this link needs to be updated
Closed
@koomie koomie self-assigned this Nov 16, 2022
@koomie koomie added the documentation Improvements or additions to documentation label Nov 16, 2022
@koomie
Copy link
Collaborator

koomie commented Nov 16, 2022

Oopsie - that is almost certainly my fault. I'll update the link.

koomie added a commit that referenced this issue Nov 16, 2022
@koomie
fix broken link (#33)
29cc4a9 
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>
@koomie
Copy link
Collaborator

koomie commented Nov 16, 2022

Fix should be live now, but follow-up if something still looks amiss.

@koomie koomie closed this as completed Nov 16, 2022
feizheng10 pushed a commit to feizheng10/omniperf that referenced this issue Dec 6, 2023
@koomie
fix broken link (ROCm#33)
a1a1228 
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>
Signed-off-by: fei.zheng <fei.zheng@amd.com>
feizheng10 pushed a commit to feizheng10/omniperf that referenced this issue Dec 20, 2023
@koomie @feizheng10
fix broken link (ROCm#33)
1b56dd3 
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@koomie koomie

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@koomie @skyreflectedinmirrors