Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import profiling results of command with ',' comma fails #76

Closed
aosewski opened this issue Jan 26, 2023 · 2 comments
Closed

Import profiling results of command with ',' comma fails #76

aosewski opened this issue Jan 26, 2023 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@aosewski
Copy link

I've successfully run full (all IP blocks) profiling of my program, which command line contains multiple commas. However when I try to import collected data to Omniperf database I get following error:

Found sysinfo file                                                                                                                                                                                                 
Traceback (most recent call last):                                                                                                                                                                                 
  File "/opt/omniperf/1.0.6/bin/omniperf", line 663, in <module>                                                                                                                                                   
    main()                                                                                                                                                                                                         
  File "/opt/omniperf/1.0.6/bin/omniperf", line 609, in main                                             
    mongo_import(args, False)                                                                                                                                                                                      
  File "/opt/omniperf/1.0.6/bin/omniperf", line 205, in mongo_import                                     
    connectionInfo, Extractionlvl = csv_converter.parse(args, profileAndImport)                                                                                                                                    
  File "/opt/omniperf/1.0.6/bin/utils/csv_converter.py", line 145, in parse                              
    db = "omniperf_" + args.team + "_" + name + "_" + soc                                                                                                                                                          
TypeError: can only concatenate str (not "numpy.int64") to str

And this is because my sysinfo.csv file contains my program command which contains multiple commas and this breaks csv file structure.

I'd be grateful for fixing this bug or any hits how to overcome this.

@coleramos425 coleramos425 added this to the v.1.0.7 milestone Jan 26, 2023
@coleramos425
Copy link
Collaborator

coleramos425 commented Jan 27, 2023

An app command containing commas is certainly an edge case that would break our import process. We'll get this patched in v1.0.7

However, looking at your included traceback this seems to be occurring because of the -t/--team and/or -n/--name you passed. They were likely integers we failed to convert to str. This is a separate issue, but one we'll also patch in v1.0.7

@coleramos425 coleramos425 self-assigned this Jan 27, 2023
@coleramos425 coleramos425 added the bug Something isn't working label Jan 27, 2023
coleramos425 added a commit that referenced this issue Jan 27, 2023
Signed-off-by: coleramos425 <colramos@amd.com>
coleramos425 added a commit that referenced this issue Jan 27, 2023
Signed-off-by: coleramos425 <colramos@amd.com>
coleramos425 added a commit that referenced this issue Jan 27, 2023
Signed-off-by: coleramos425 <colramos@amd.com>
@coleramos425
Copy link
Collaborator

Issues have been fixed. This is will be included in our release early next week. Thank you.

feizheng10 pushed a commit to feizheng10/omniperf that referenced this issue Dec 6, 2023
Signed-off-by: coleramos425 <colramos@amd.com>
Signed-off-by: fei.zheng <fei.zheng@amd.com>
feizheng10 pushed a commit to feizheng10/omniperf that referenced this issue Dec 6, 2023
Signed-off-by: coleramos425 <colramos@amd.com>
Signed-off-by: fei.zheng <fei.zheng@amd.com>
feizheng10 pushed a commit to feizheng10/omniperf that referenced this issue Dec 6, 2023
Signed-off-by: coleramos425 <colramos@amd.com>
Signed-off-by: fei.zheng <fei.zheng@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants