Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle "No Detected GPU" #85

Closed
coleramos425 opened this issue Feb 9, 2023 · 1 comment
Closed

Handle "No Detected GPU" #85

coleramos425 opened this issue Feb 9, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@coleramos425
Copy link
Collaborator

coleramos425 commented Feb 9, 2023

If for whatever reason, if a system's GPU is unavailable, the rocm-smi method of detecting system information leads to issues

i.e.

$ omniperf profile -n test -- ls
ROC Profiler:  opt/rocm-5.2.0/.info/version
Traceback (most recent call last):
  File "/bin/omniperf", line 663, in <module>
    main()
  File "/bin/omniperf", line 474, in main
    args.target = get_soc()  # Must have a valid soc in profile mode
  File "/bin/omniperf", line 83, in get_soc
    mspec = specs.get_machine_specs(0)
  File "/omniperf/1.0.6/bin/utils/specs.py", line 233, in get_machine_specs
    freq = search(device, rocm_smi).split()
AttributeError: 'NoneType' object has no attribute 'split'

In this situation could we handle this more gracefully? Check the results of the run commands in machine specs.

@coleramos425 coleramos425 added the enhancement New feature or request label Feb 9, 2023
@coleramos425 coleramos425 added this to the v.1.0.7 milestone Feb 9, 2023
@coleramos425 coleramos425 self-assigned this Feb 9, 2023
@coleramos425 coleramos425 changed the title Handel "No Detected GPU" Handle "No Detected GPU" Feb 9, 2023
coleramos425 added a commit that referenced this issue Feb 21, 2023
Signed-off-by: coleramos425 <colramos@amd.com>
@coleramos425
Copy link
Collaborator Author

Fix added to dev branch. Closing issue.

coleramos425 added a commit that referenced this issue Feb 21, 2023
Signed-off-by: coleramos425 <colramos@amd.com>
feizheng10 pushed a commit to feizheng10/omniperf that referenced this issue Dec 6, 2023
Signed-off-by: coleramos425 <colramos@amd.com>
Signed-off-by: fei.zheng <fei.zheng@amd.com>
feizheng10 pushed a commit to feizheng10/omniperf that referenced this issue Dec 6, 2023
Signed-off-by: coleramos425 <colramos@amd.com>
Signed-off-by: fei.zheng <fei.zheng@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant