Improve logging #335
Merged
Improve logging #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coleramos425
force-pushed
the
improve-logging
branch
4 times, most recently
from
395d835
to
00b5001
Compare
Signed-off-by: colramos-amd <colramos@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
coleramos425
force-pushed
the
improve-logging
branch
from
00b5001
to
0f6df49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the color introduced in the logging module to the rest of the log text. See an example below:
$ omniperf profile -n mix -V -- ./mixbenchYou'll see the default loglevel
INFOis colored white, which matches other output and helps draw attention to warnings/errors. I've also changed Omniperf behavior s.t. colored logging is always on. You'll noticeDEBUG,ERROR, andWARNINGare the only log levels that output their type to the terminal (i.e., DEBUG: <msg>).