-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
omnitrace-run executable - required for running binary writes #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ensure LD_PRELOAD for libomnitrace-dl.so - convert config options into command-line options
- updates to tsettings - updates to argparser
- throw error if get_env<bool> has empty string
- minor tweaks to categories of settings
- add argparse for common handling of argument parsers
- fix handling of --trace-file (OMNITRACE_PERFETTO_FILE)
- updated to use omnitrace::argparse functions
- remove choices for --cpu-events and --gpu-events
|
jrmadsen
commented
Mar 11, 2023
- fix pedantic warning
- remove testing args that may not be there in some builds
- disable roctracer_data when roctracer not enabled
- allow DEFAULT_MODULE and LIBRARY_MODULE
- support get_env for enums
- Add "mode" category to OMNITRACE_MODE
- remove debug print statement
- change var init
- use --help instead of -?
- tweak header include style
- add_ld_preload func - launcher and command member variables in parser_data - support launcher
- clean up and reworked
- require LD_PRELOAD with binary rewrite - dl::InstrumentMode - dl::get_instrumented() - verify_instrumented_preloaded() - omnitrace_set_instrumented(int) - relocated omnitrace_main from main.c to dl.cpp - omnitrace_set_env does not dlopen libomnitrace - omnitrace_set_main(func_ptr) [internal API] - OMNITRACE_HIDDEN_API -> OMNITRACE_INTERNAL_API
- adhere to LD_PRELOAD requirementsa - invoke omnitrace_set_instrumented - binary rewrite does not instrument main - binary rewrite does not instrument call to omnitrace_init - runtime instr does not instrument main - runtime instr does not instrument call to omnitrace_init
- LD_PRELOAD requirement necessitates minor version increment
- fix ambiguous get_env calls
- fix issue with temporaries
- runtime instrumentation does not work if libomnitrace-dl is preloaded
- define dl::InstrumentMode in dl.hpp - handle instrumentation via setprofile libpyomnitrace - do not push trace in omnitrace_init
- move header to dl subdirectory - omnitrace::omnitrace-headers include omnitrace-dl folder - use InstrumentMode in omnitrace-instrument
- Use omnitrace-run on instrumented exes
- add omnitrace-run to examples of running binary rewritten exes
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cmake
Modifies the CMake build system
continuous-integration
Updates to continuous integration
enhancement
New feature or request
libomnitrace-dl
Involves omnitrace-dl library
libpyomnitrace
Involves the omnitrace python bindings
new feature
Introduces new feature
omnitrace-instrument
Involves the omnitrace-instrument executable (binary instrumenter)
omnitrace-run
Involves the omnitrace-run executable
omnitrace-sample
Involves the omnitrace-sample executable
submodule
Updates a git submodule
testing
Extends/improves/modifies testing
timemory
Issue affects/involves timemory features/capabilities
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
omnitrace-sample
except that it works with instrumented binarieslibomnitrace-dl.so
Usage
Binary rewrite
Sampling
The following two command are effectively identical:
Help Menu