Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roctracer perfetto flow fixes #267

Merged
merged 6 commits into from Mar 23, 2023
Merged

Roctracer perfetto flow fixes #267

merged 6 commits into from Mar 23, 2023

Conversation

jrmadsen
Copy link
Collaborator

@jrmadsen jrmadsen commented Mar 23, 2023 •
edited

Roctracer Updates

  • fix perfetto::Flow
    • use roctracer correlation ID instead of critical trace correlation ID -- this appears to have been a mistake due to poor variable names
  • renamed ambiguous _cid, _parent_cid, _corr_id variables to _crit_cid, _parent_crit_cid, _roct_cid
  • use atomic_{mutex,lock} instead of STL mutex/lock
  • support for individual perfetto annotations for HIP API args
  • OMNITRACE_PERFETTO_COMPACT_ROCTRACER_ANNOTATIONS option for controlling compact vs. individual perfetto annotations for HIP API args

Other Updates

  • update timemory submodule
    • argparser updates
  • testing label updates
  • config::get_setting_value<Tp> returns std::optional<Tp> instead of std::pair<bool, Tp>
    • the pair was confusing and potentially error-prone when Tp == bool

@jrmadsen
testing label updates
e3a00d4 
- automatically add "gpu", "roctracer", "rocm-smi", and "rocprofiler" test labels when appropriate
@jrmadsen
Bump version to v1.9.1
8d02edf
@jrmadsen
roctracer and config updates
91c98b3 
- fix perfetto::Flow
  - use roctracer correlation ID instead of critical trace correlation ID
- renamed ambiguous _cid, _parent_cid, _corr_id variables to _crit_cid, _parent_crit_cid, _roct_cid
- use atomic_{mutex,lock} instead of STL mutex/lock
- support for individual perfetto annotations for HIP API args
- OMNITRACE_PERFETTO_COMPACT_ROCTRACER_ANNOTATIONS option for controlling compact vs. individual perfetto annotations for HIP API args
@jrmadsen
Update timemory submodule
371105d 
- argparser updates
  - help prints to std::cout by default now
  - supports setting custom ostream
@jrmadsen jrmadsen added bug fix Fixes a bug perfetto Issue affects/involves perfetto features/capabilities timemory Issue affects/involves timemory features/capabilities roctracer GPU kernel tracing testing Extends/improves/modifies testing submodule Updates a git submodule configuration Changes/involves configuration options labels Mar 23, 2023
@jrmadsen
cmake formatting
2592ffb
@jrmadsen
config::get_setting_value updates
eb34697 
- config::get_setting_value returns std::optional instead of std::pair<bool, Tp>
@jrmadsen jrmadsen merged commit 279a8e0 into ROCm:main Mar 23, 2023
48 checks passed
@jrmadsen jrmadsen deleted the roctracer-perfetto-flow-fixes branch March 23, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug fix Fixes a bug configuration Changes/involves configuration options perfetto Issue affects/involves perfetto features/capabilities roctracer GPU kernel tracing submodule Updates a git submodule testing Extends/improves/modifies testing timemory Issue affects/involves timemory features/capabilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem with flow event HSA operations (fill, copy) show incorrect perfetto flows
1 participant
@jrmadsen