Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rocprofler_iterate_info workaround + omnitrace-avail update #270

Merged

Conversation

jrmadsen
Copy link
Collaborator

@jrmadsen jrmadsen commented Mar 29, 2023

Bug Fix

  • provides workaround for rocprofiler_iterate_info behavior change in ROCm 5.4.0-3
  • update timemory submodule with argparse tweaks
  • updates hsa_rsrc_factory.{hpp,cpp}
  • closes GPU HW counter metrics broken in ROCm 5.4 #268
    • a workaround to this issue was found but rocprofiler needs to be patched

Additional Changes

  • Bump version to 1.9.2
  • Updates to version info: (A) printed below banner, (B) in metadata.json, and (C) via --version argument to exes
    • define OMNITRACE_LIBRARY_ARCH (via CMAKE_LIBRARY_ARCHITECTURE)
    • define OMNITRACE_SYSTEM_NAME (via CMAKE_SYSTEM_NAME)
    • define OMNITRACE_SYSTEM_PROCESSOR (via CMAKE_SYSTEM_PROCESSOR)
    • define OMNITRACE_SYSTEM_VERSION (via CMAKE_SYSTEM_VERSION)
    • define OMNITRACE_COMPILER_ID (via CMAKE_CXX_COMPILER_ID)
    • define OMNITRACE_COMPILER_VERSION (via CMAKE_CXX_COMPILER_VERSION)
  • Tweak to some verbose messages related to perfetto
  • Colorized log in omnitrace-avail

- provides workaround for rocprofiler_iterate_info behavior change in ROCm 5.4.0-3
- update timemory submodule with argparse tweaks
- updates hsa_rsrc_factory.{hpp,cpp}
- colorized log in omnitrace-avail
- Bump version to 1.9.2
@jrmadsen jrmadsen added bug fix Fixes a bug timemory Issue affects/involves timemory features/capabilities libomnitrace Involves omnitrace library omnitrace-avail Involves the omnitrace-avail executable (info tool) submodule Updates a git submodule rocprofiler GPU kernel HW counters labels Mar 29, 2023
- timemory's component::empty_base inherits from concepts::component so direct inheritance was removed
- defined as "" when OMNITRACE_HIP_VERSION_MAJOR==0
- define OMNITRACE_LIBRARY_ARCH (via CMAKE_LIBRARY_ARCHITECTURE)
- define OMNITRACE_SYSTEM_NAME (via CMAKE_SYSTEM_NAME)
- define OMNITRACE_SYSTEM_PROCESSOR (via CMAKE_SYSTEM_PROCESSOR)
- define OMNITRACE_SYSTEM_VERSION (via OMNITRACE_SYSTEM_VERSION)
- define OMNITRACE_COMPILER_ID (via CMAKE_CXX_COMPILER_ID)
- define OMNITRACE_COMPILER_VERSION (via CMAKE_CXX_COMPILER_VERSION)
- include this info in metadata
- include subset of this info in --version for bin tools
- tweak to perfetto verbose messages
@jrmadsen jrmadsen added omnitrace-instrument Involves the omnitrace-instrument executable (binary instrumenter) omnitrace-sample Involves the omnitrace-sample executable omnitrace-causal Involves the omnitrace-causal executable libomnitrace-core Internal library containing core capabilities omnitrace-run Involves the omnitrace-run executable labels Mar 30, 2023
@jrmadsen jrmadsen merged commit 4ed5f3e into ROCm:main Mar 30, 2023
48 checks passed
@jrmadsen jrmadsen deleted the gpu-hw-counters-workaround-for-rocm-5.4.x branch March 30, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Fixes a bug libomnitrace Involves omnitrace library libomnitrace-core Internal library containing core capabilities omnitrace-avail Involves the omnitrace-avail executable (info tool) omnitrace-causal Involves the omnitrace-causal executable omnitrace-instrument Involves the omnitrace-instrument executable (binary instrumenter) omnitrace-run Involves the omnitrace-run executable omnitrace-sample Involves the omnitrace-sample executable rocprofiler GPU kernel HW counters submodule Updates a git submodule timemory Issue affects/involves timemory features/capabilities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GPU HW counter metrics broken in ROCm 5.4
1 participant