Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix thread index values #287

Merged
merged 5 commits into from
Jun 16, 2023
Merged

Conversation

jrmadsen
Copy link
Collaborator

  • ensure that all background threads via PTL and perfetto are not accidentally indexed as user threads
    • PTL submodule waits for threads to start before proceeding
    • Initialize perfetto after pthread_create wrapper activated
  • tweak to backtrace component
    • exclude gotcha call-tree
  • tweak to callchain component
    • callchain::get sorts based on timestamp
    • callchain::sample supports duplicate IPs (e.g. recursion)

@jrmadsen jrmadsen added libomnitrace Involves omnitrace library sampling Statistical sampling via interrupts submodule Updates a git submodule PTL Involves the Parallel Tasking Library (PTL) labels Jun 15, 2023
- PTL submodule waits for threads to start before proceeding
- perfetto thread creation after pthread_create wrapped
- exclude gotcha call-tree
- callchain::get sorts based on timestamp
- callchain::sample supports duplicate IPs (recursion)
@jrmadsen jrmadsen merged commit de9f0e4 into ROCm:main Jun 16, 2023
48 checks passed
@jrmadsen jrmadsen deleted the fix-thread-index-values branch June 16, 2023 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libomnitrace Involves omnitrace library PTL Involves the Parallel Tasking Library (PTL) sampling Statistical sampling via interrupts submodule Updates a git submodule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant