Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to skip barrier marker events in traces #320

Merged
merged 5 commits into from
Jan 10, 2024
Merged

Add option to skip barrier marker events in traces #320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
720103d
Add option to skip barrier marker events in traces
tbennun Dec 14, 2023
ccb9486
Formatting
tbennun Dec 14, 2023
9f951e6
Apply review suggestions
tbennun Dec 14, 2023
668bc0b
clang-format
tbennun Dec 18, 2023
e163821
Formatting
jrmadsen Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions source/lib/core/config.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -624,6 +624,10 @@ configure_settings(bool _init)
"HSA API type to collect", "", "roctracer", "rocm",
"advanced");

OMNITRACE_CONFIG_SETTING(bool, "OMNITRACE_ROCTRACER_DISCARD_BARRIERS",
"Skip barrier marker events in traces", false, "roctracer",
"rocm", "advanced");

OMNITRACE_CONFIG_SETTING(
std::string, "OMNITRACE_ROCM_EVENTS",
"ROCm hardware counters. Use ':device=N' syntax to specify collection on device "
Expand Down
8 changes: 6 additions & 2 deletions source/lib/omnitrace/library/roctracer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -868,8 +868,11 @@ hip_activity_callback(const char* begin, const char* end, void* arg)
using Phase = critical_trace::Phase;

if(!trait::runtime_enabled<comp::roctracer>::get()) return;
static auto _kernel_names = std::unordered_map<const char*, std::string>{};
static auto _indexes = std::unordered_map<uint64_t, int>{};
static auto _kernel_names = std::unordered_map<const char*, std::string>{};
static auto _indexes = std::unordered_map<uint64_t, int>{};
static auto _skip_barrier_packets =
config::get_setting_value<bool>("OMNITRACE_ROCTRACER_DISCARD_BARRIERS")
.value_or(false);
const roctracer_record_t* record = reinterpret_cast<const roctracer_record_t*>(begin);
const roctracer_record_t* end_record =
reinterpret_cast<const roctracer_record_t*>(end);
Expand All @@ -896,6 +899,7 @@ hip_activity_callback(const char* begin, const char* end, void* arg)
}
if(record->domain != ACTIVITY_DOMAIN_HIP_OPS) continue;
if(record->op > HIP_OP_ID_BARRIER) continue;
if(_skip_barrier_packets && record->op == HIP_OP_ID_BARRIER) continue;

const char* op_name =
roctracer_op_string(record->domain, record->op, record->kind);
Expand Down