Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable previously disabled FA related Operators in UTs #1389

Open
wants to merge 36 commits into
base: rocm6.2_internal_testing
Choose a base branch
from
Open

Enable previously disabled FA related Operators in UTs #1389

wants to merge 36 commits into from
+504 −104

Conversation

xinyazhang
Copy link

@xinyazhang xinyazhang commented Apr 8, 2024 •
edited

They were disabled in AOTriton V1, but V2 should fix most of them.

Passed with

PYTORCH_TEST_WITH_ROCM=1 PYTORCH_TESTING_DEVICE_ONLY_FOR="cuda" python test/test_meta.py -k flash_attention -v
PYTORCH_TEST_WITH_ROCM=1 PYTORCH_TESTING_DEVICE_ONLY_FOR="cuda" python test/test_ops.py -k flash_attention -v
PYTORCH_TEST_WITH_ROCM=1 PYTORCH_TESTING_DEVICE_ONLY_FOR="cuda" python test/test_meta.py -k functional_scaled_dot_product_attention_cuda -v
PYTORCH_TEST_WITH_ROCM=1 PYTORCH_TESTING_DEVICE_ONLY_FOR="cuda" python test/test_ops.py -k functional_scaled_dot_product_attention_cuda -v

image
image
image

pruthvistony and others added 30 commits March 12, 2024 11:53
@pruthvistony
Add the related_commits file
d83f528
@pruthvistony
Add the UT test_times_file
f2f5b5d
@rraminen @jithunnair-amd @pruthvistony
[SOW MS3] Centos stream9 PyTorch image support (#1090)
40a3160 
* changes to build Centos stream 9 images

* Added scripts for centos and centos stream images

* Added an extra line

* Add ninja installation

* Optimized code

* Fixes

* Add comment

* Optimized code

* Added AMDGPU mapping for ROCm 5.2 and invalid-url for rocm_baseurl

Co-authored-by: Jithun Nair <37884920+jithunnair-amd@users.noreply.github.com>
@pruthvistony
Updated to latest conda for CentOS stream 9
3f71e55
@pruthvistony
Temporarily skip test_conv3d_64bit_indexing
8661299 
- Rocblas API support is requested
- SWDEV-383635 & sub task - SWDEV-390218
@wenchenvincent @jithunnair-amd @pruthvistony
Sync updates from hipify_torch. (#1168)
3632eec 
Co-authored-by: Jithun Nair <37884920+jithunnair-amd@users.noreply.github.com>
@pruthvistony @BeyondPerception
Enable tensorpipe with hip_basic backend (#1135)
68cac05 
* Add hip_basic tensorpipe support to PyTorch

* Enabling hip_basic for Tensorpipe for pyTorch

* removing upstream tensorpipe module

* Adding ROCm specific tensopipe submodule

* tensorpipe submodule updated

* Update the hip invalid device string

* Added ignore for tensorpipe git submodule

* Moved include of tensorpipe_cuda.h to hipify

* Updates based on review comments

* Defining the variable __HIP_PLATFORM_AMD__

* Enabling the UTs

Co-authored-by: Ronak Malik <Ronak.Malik@amd.com>
@pruthvistony
Updates to build on Jammy
716b6e2 
- Fortran package installation moved after gcc
- Update libtinfo search code in cmake1
- Install libstdc++.so
@pruthvistony
Fix lstsq related regressions (part of SWDEV-392820)
4042400
@pruthvistony
[UB22.04] Updates to support latest scipy
21d1194
@pruthvistony
Build required version of libpng for CentOS7
0f370f9
@pruthvistony
Update tensorpipe submodule to support ROCm 6.0
95c4b69
@pruthvistony
Set ROCM_PATH in env for centOS docker container
f689fa1
@pruthvistony
Updated condition for libstc++ for Jammy
17460f9
@jataylo @pruthvistony
Skip ddp apply_optim_in_bwd tests for gloo (#1302)
b1f6459 
To resolve https://ontrack-internal.amd.com/browse/SWDEV-403530 and https://ontrack-internal.amd.com/browse/SWDEV-419837. For more context check upstream issue pytorch#111834
@pruthvistony
Changes to support docker v23
a209b77 
Reversed the condition as required
@pruthvistony
[CS9] Updates to CentOS stream 9 build (#1326)
44f7860 
- Add missing common_utils.sh
- Update the install vision part
- Move to amdgpu rhel 9.3 builds
- Update to pick python from conda path
- Add a missing package
- Add ROCM_PATH and magma
- Updated repo radeon path
@pruthvistony
Update to hipify mapping
3277ca0
@pruthvistony
Correcting usage of USE_ROCM
9aa41ee
@xinyazhang @pruthvistony
Enable gesvda for ROCM >= 6.1 (#1339)
b3ac140 
This also fixes a problem in gesvd driver when UV is not needed.
@pruthvistony
Increase lifespan of test-times files
eb77bc2 
- build_environment is hard coded to value from upstream when
  branch for created, since the dev/QA ENV build_environment
  value can be varing
@xinyazhang @pruthvistony
Fixes CI build script (#1350)
6bd1ef8 
* Fix the parsing of /etc/os-release

The old code parses OS_DISTRO as 'PRETTY_Ubuntu' on Ubuntu and thus
never links to libtinfo correctly.

* Configurable CMAKE_PREFIX_PATH in CI script.
@pruthvistony
[NO CP] Temporary dumping of test exec log to stderr
acff1c1 
- This is done as per QA request, needs to be reverted and
  not required to be cherry-picked into later releases.
@jataylo @pruthvistony
Add skipIfRocmArch decorator for Navi skips (#1356)
0b08ab6
@BLOrange-AMD @pruthvistony
Converted NAVI check as a function (#1364)
d0d25c3 
* Moved NAVI check to the test file

* Revised NAVI check as a function
@pruthvistony
Triton build conditionalized on ROCM_VERSION
7c76d3b
@jeffdaily @pruthvistony
relax tol for flaky nansum_out_dtype_cuda_float32 test
ca9a30c 
TestReductionsCUDA.test_nansum_out_dtype_cuda_float32 would fail or pass
depending on the random inputs. Observed by ROCm internal QA testing.
@pruthvistony
Remove ROCmloops specific test
ab06040
@pruthvistony
Removing DOCKER_BUILDKIT=1 to support internal CI
8036be2
@pruthvistony
Merge pull request #1367 from ROCm/IFU_CP_03122024
d4ce7aa 
IFU cherry-picks into rocm6.2_internal_testing
pruthvistony and others added 6 commits March 12, 2024 15:39
@pruthvistony
Triton commit update
a6feb59 
- Commit from branch pytorch/rocm6.2_internal_testing
@pragupta
Bad import in test_torchinductor and skip torchvision related UT (#1374)
c838806
@pragupta
skip test_inductor_freezing failing UTs (#1375)
a990b07
@pragupta
Skip test_mm_triton_kernel_benchmark (#1376)
5d7b0c3 
* Running triton kernel on ROCM only has one GB/s metric reported

* Update test_kernel_benchmark.py
@jeffdaily
add -fclang-abi-compat=17 to HIP_HIPCC_FLAGS (#1377)
de739ad 
C++20 mangling rules were recently added to hip-clang. This flag
maintains compatibility since pytorch is at C++17. Otherwise the linker
fails.
@xinyazhang
Enable previously disabled FA related Operators in UTs
2f4f158
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffdaily jeffdaily Awaiting requested review from jeffdaily jeffdaily is a code owner

@jithunnair-amd jithunnair-amd Awaiting requested review from jithunnair-amd jithunnair-amd is a code owner

@jataylo jataylo Awaiting requested review from jataylo jataylo is a code owner

@pruthvistony pruthvistony Awaiting requested review from pruthvistony pruthvistony is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@xinyazhang @pruthvistony @rraminen @wenchenvincent @jataylo @BLOrange-AMD @jeffdaily @pragupta