Enable fp8 inductor unit tests #1421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffdaily
reviewed
May 22, 2024
test/inductor/test_fp8.py
Outdated
Comment on lines
41
to
44
| elif float8_dtype == torch.float8_e4m3fnuz: | ||
| x = x.clamp(min=-1 * E4M3_MAX_POS, max=E4M3_MAX_POS) | ||
| elif float8_dtype == torch.float8_e5m2fnuz: | ||
| x = x.clamp(min=-1 * E5M2_MAX_POS, max=E5M2_MAX_POS) |
There was a problem hiding this comment.
Should these be *FNUZ (E4M3FNUZ_MAX_POS and E5M2FNUZ_MAX_POS)?
pragupta
approved these changes
May 23, 2024
pruthvistony
approved these changes
May 29, 2024
pruthvistony
merged commit ce5e7e7
into
ROCm:rocm6.2_internal_testing
1 check was pending
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.