remove const for ScopeGuard operator #156
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With gcc 14 on Fedora rawhide, there is this build error
[ 3%] Building CXX object rocm_smi/CMakeFiles/rocm_smi64.dir/__/src/rocm_smi_device.cc.o
In file included from rocm_smi_lib/src/rocm_smi_device.cc:67:
rocm_smi_lib/include/rocm_smi/rocm_smi_utils.h: In member function ‘amd::smi::ScopeGuard<lambda>& amd::smi::ScopeGuard<lambda>::operator=(const amd::smi::ScopeGuard<lambda>&)’:
/home/trix/rocm/rocm_smi_lib/include/rocm_smi/rocm_smi_utils.h:222:18: error: assignment of member ‘dismiss_’ in read-only object
222 | rhs.dismiss_ = true;
| ~~~~~~~~~~~~~^~~~~~
The rhs parameter can not be const and setting a sideeffect.
So remove const
Signed-off-by: Tom Rix <trix@redhat.com>
trixirt
requested review from
bill-shuzhou-liu,
dmitrii-galantsev,
charis-poag-amd and
oliveiradan
as code owners
|
@cfreehill , could you check this? rocm_smi_lib fails to compile with clang-19 too. Original commit was 8e03d10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With gcc 14 on Fedora rawhide, there is this build error
[ 3%] Building CXX object rocm_smi/CMakeFiles/rocm_smi64.dir/__/src/rocm_smi_device.cc.o In file included from rocm_smi_lib/src/rocm_smi_device.cc:67: rocm_smi_lib/include/rocm_smi/rocm_smi_utils.h: In member function ‘amd::smi::ScopeGuard& amd::smi::ScopeGuard::operator=(const amd::smi::ScopeGuard&)’: /home/trix/rocm/rocm_smi_lib/include/rocm_smi/rocm_smi_utils.h:222:18: error: assignment of member ‘dismiss_’ in read-only object
222 | rhs.dismiss_ = true;
| ~~~~~~~~~~~~~^~~~~~
The rhs parameter can not be const and setting a sideeffect. So remove const