change CMAKE_HOST_SYSTEM_PROCESSOR to CMAKE_SYSTEM_PROCESSOR #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calandracas606
requested review from
bill-shuzhou-liu,
dmitrii-galantsev,
charis-poag-amd and
oliveiradan
as code owners
dmitrii-galantsev
approved these changes
Mar 28, 2024
|
Thank you! I'm submitting the change internally. It should make it to github in a couple days. |
|
Merged in 38d1275 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes build failure when cross compiling.
This should be CMAKE_SYSTEM_PROCESSOR, which will default to CMAKE_HOST_SYSTEM_PROCESSOR when not cross compiling
https://cmake.org/cmake/help/latest/variable/CMAKE_SYSTEM_PROCESSOR.html
https://cmake.org/cmake/help/latest/variable/CMAKE_HOST_SYSTEM_PROCESSOR.html
Tested cross compiling to aarch64, armv6l, and armv7l (although its extremely unlikely that 32-bit arm will ever use this library)