Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rocmsmidocs reorg #168

Open
wants to merge 251 commits into
base: amd-staging
Choose a base branch
from
Open

Rocmsmidocs reorg #168

wants to merge 251 commits into from

Conversation

Rmalavally
Copy link
Contributor

No description provided.

Ori-Messinger and others added 30 commits July 27, 2021 15:22
@Ori-Messinger @bill-shuzhou-liu
ROCm SMI Python CLI: Add Zero Padding to Device Model
034caf6 
Use zero padding for the hexadecimal value 'device_model' inside
showProductName with a padding length of 4.

Signed-off-by: Ori Messinger <Ori.Messinger@amd.com>
Change-Id: I962b94d414c6ba050d951486ad9e7559123f8850
@Ori-Messinger @bill-shuzhou-liu
ROCm SMI Python CLI: Fix printLog Collisions
8d5ced1 
Python's default 'print' implementation is not thread safe, causing
empty lines to be printed during multithreaded code execution.

This fixes the --showevents output for multi-GPU systems.

Signed-off-by: Ori Messinger <Ori.Messinger@amd.com>
Change-Id: I72f7341cdf4401f1fed4cd8f7d7a4a90bf9a3a4c
@hkasivis @bill-shuzhou-liu
rocm_smi.py: Remove extraneous line during process termination
cef1974 
During the tail end when process is terminating, subprocess module fails
to find the process. This results in extraneous printing of a line with
char 'b'. Fix this.

BUG: SWDEV-296409

Signed-off-by: Harish Kasiviswanathan <Harish.Kasiviswanathan@amd.com>
Change-Id: I39aacf8ae948a5acec0aa93296cc0e0aec88b3ef
@bill-shuzhou-liu
[rocm_smi.py] add secondary die check.
2c39e6c 
Signed-off-by: Elena Sakhnovitch <Elena.Sakhnovitch@amd.com>
Change-Id: I46618002c1967ec115db88becbaba9e7c0a08af1
@bill-shuzhou-liu
[rocm_smi.py] --showpower error bugfix
6a01b6b 
Fix error message in -P for secondary die

Signed-off-by: Elena Sakhnovitch
Change-Id: Ica3c0a83b565d2231fad23389b9378056a0f56b3
@bill-shuzhou-liu
Add -g compiler option for ADDRESS_SANITIZER
1256542 
Add -g compiler option for Address Sanitizer

Change-Id: I958fefa6c4b5871c29734ab1d4ec238c9e073192
(cherry picked from commit 42d39d3)
@bill-shuzhou-liu
support rocm_smi_lib version in the header file
5d3f3a1 
Package the rocm_smi64Config.h into deb/rpm.

Change-Id: Ic4ba90646a0dbeb8bc2dd4edf455004b1a7ea859
(cherry picked from commit 26874d2)
@hkasivis @bill-shuzhou-liu
Fall back to pci-ids if FRU product_name is empty
b9cc3d1 
rocm-smi --showproductname will not show "Card series" in its output if
product_name exported by Kernel is empty string. This has been raised a
regression by customer.

BUG: SWDEV-297228

Signed-off-by: Harish Kasiviswanathan <Harish.Kasiviswanathan@amd.com>
Change-Id: I9aae24778e2d3a30aa661d8f338278c1666590fb
(cherry picked from commit 7a8c3f3)
@bill-shuzhou-liu
rocm_smi_lib: add gpu_metrics_v1_3 support
bbd7017 
Signed-off-by: Elena Sakhnovitch
Change-Id: I4a9dedc80b8fce60e12c5baf8651d54d16a6a41c
(cherry picked from commit fee82af)
@bill-shuzhou-liu
rocm_smi_lib: fix gpu_metrics_v1_3 support
1447c83 
Signed-off-by: Elena Sakhnovitch
Change-Id: Ia7a6b17eb0f317465613ba92ae7548a221c46ee3
(cherry picked from commit 5e1bfca)
@bill-shuzhou-liu
Add cmake target for rocm_smi
e6692c0 
rocm_smi will provide cmake files exporting the INCLUDE/LIBRARY targets.

Change-Id: I1943a3142bdc0abd8f03ff62e12e947aac835401
(cherry picked from commit 088fe48)
@kentrussell
Merge amd-staging into amd-master
98baeca 
 Conflicts:
	python_smi_tools/rocm_smi.py

Change-Id: Iad29365d4dd0ac30d19013dae31105343b126733
Merge amd-staging into amd-master
3ef2132 
Signed-off-by: Hao Zhou <Hao.Zhou@amd.com>
Change-Id: Ic324e60cd33d0db539537a978710d9c87c1dbd2e
Merge amd-staging into amd-master 20211216
bd2b8e6 
Signed-off-by: Hao Zhou <Hao.Zhou@amd.com>
Change-Id: If1f7f0ebfe63c4d2d2298523385dc2695f574680
@lmoriche
Don't use NDEBUG when the intent is !DEBUG
9f87197 
CMakeLists.txt does not set up the DEBUG macro correctly to mean
!NDEBUG, so, as a workaround, replace all uses of ifdef NDEBUG with
ifndef DEBUG in the library sources.

Change-Id: I408adb36d1a2310fb894a486574469662ebb27cd
Merge amd-staging into amd-master 20220121
6e7c204 
Signed-off-by: Hao Zhou <Hao.Zhou@amd.com>
Change-Id: I0076befd07044063076f31332baa14ea0bdfb5b4
Merge amd-staging into amd-master 20220128
25e32e9 
Signed-off-by: Hao Zhou <Hao.Zhou@amd.com>
Change-Id: I4d7d30b28e80d74fe17eaeb7e30e260829f73d83
Merge amd-staging into amd-master 20220209
1da93b3 
Signed-off-by: Hao Zhou <Hao.Zhou@amd.com>
Change-Id: Ibf40dc4d7c66f2d926d37f09d493d06fb52b183e
Merge amd-staging into amd-master 20220211
19c5691 
Signed-off-by: Hao Zhou <Hao.Zhou@amd.com>
Change-Id: I95fd0cafb212a3e0f64b58ba6a009a4cd37ae0a6
Merge amd-staging into amd-master 20220224
35ad11c 
Signed-off-by: Hao Zhou <Hao.Zhou@amd.com>
Change-Id: I371300c32821939aec486a70d22bcdd005971e95
Merge amd-staging into amd-master 20220303
f02fe43 
Signed-off-by: Hao Zhou <Hao.Zhou@amd.com>
Change-Id: I3b870b9944df71ab11b2c9de176c74351f89068a
[rocm_smi.py] resetPowerOverdrive fix
741174f 
resetPowerOverdrive: improve output messages.

Signed-off-by: Elena Sakhnovitch
Change-Id: Ic5b9084f0637458c36e460231f2d3622b0a23aa6
Merge amd-staging into amd-master 20220310
87af568 
Signed-off-by: Hao Zhou <Hao.Zhou@amd.com>
Change-Id: I8fcf65fa293919572468a786409db75ea97c1097
@zhang2amd
[rocm_smi.py]: fix input error type for --setclock
5d7c30e 
signed-off-by: Elena Sakhnovitch
Change-Id: I9626978780f360c591fb8908f5b759f2289dff0b
@sreekantsomasekharan @zhang2amd
Add blacklist filter 'virtualization' for rsmi tests failing in SRIOV
d596f72 
Change-Id: Ibbaef092482c0b78ecd86a29f0b9b4331b51abe2
Merge amd-staging into amd-master 20220317
d1db525 
Signed-off-by: Hao Zhou <Hao.Zhou@amd.com>
Change-Id: I1aaf47be05ceb7c46ee25b34509c11afa3fa7b54
@kentrussell
README: Remove restrictive licensing language
b17b3b2 
Also update copyright years

Signed-off-by: Kent Russell <kent.russell@amd.com>
Change-Id: Ic9ead543c4937680afc1957623c4d5fcbfbd58b0
(cherry picked from commit 8557131)
Merge amd-staging into amd-master 20220321
1a8a51f 
Signed-off-by: Hao Zhou <Hao.Zhou@amd.com>
Change-Id: Id5ca7b883f0993facac1f419a7633019756ecd98
@sreekantsomasekharan @kentrussell
make string variable 'tpath' an empty string.
bd95425 
string variable not being empty can lead to incorrect compilation
and corrupted output.

Change-Id: Ie66756c28aef7417759c29387500970a8b53e44c
Merge amd-staging into amd-master 20220325
4ebad75 
Signed-off-by: Hao Zhou <Hao.Zhou@amd.com>
Change-Id: I2f1e5279c677e0d63975f6f2755b0519536b7345
@Rmalavally
Copy link
Contributor Author

Why is there only one file in the Reference folder? image

We are linking to the Doxygen-generated HTML files directly from the toc.yml.in file. This is the additional file from the Component team. I have reached out to the Component team for help. This content is not rendered on the ROCm docs portal even today.
https://rocm.docs.amd.com/projects/rocm_smi_lib/en/latest/python_api.html

@Rmalavally
Update use-cpp.rst
337f362 
Leo's feedback
@Rmalavally
Update use-python.md
57a115d 
Leo's feedback
@Rmalavally
Copy link
Contributor Author

These How to titles don't line up: image image

Fixed.

@Rmalavally
Copy link
Contributor Author

Why is there only one file in the Reference folder? image

Fixed.

@Rmalavally
Copy link
Contributor Author

These How to titles don't line up: image image

Fixed.

@Rmalavally
Update index.rst
0500480 
Added a link to AMD SMI
@Rmalavally
Update index.rst
9b92547 
Updated note
@Rmalavally
Update index.rst
14f6f88
@Rmalavally
Update index.rst
2a7e17c
@Rmalavally
Update _toc.yml.in
a57539e 
added API to reference
@Rmalavally
Update index.rst
cf1f38a 
Added API to Reference
@marifamd marifamd marked this pull request as ready for review May 15, 2024 15:18
@dmitrii-galantsev dmitrii-galantsev changed the base branch from develop to amd-staging July 8, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samjwu samjwu samjwu left review comments

@lpaoletti lpaoletti lpaoletti approved these changes

@bill-shuzhou-liu bill-shuzhou-liu Awaiting requested review from bill-shuzhou-liu bill-shuzhou-liu is a code owner

@dmitrii-galantsev dmitrii-galantsev Awaiting requested review from dmitrii-galantsev dmitrii-galantsev is a code owner

@charis-poag-amd charis-poag-amd Awaiting requested review from charis-poag-amd charis-poag-amd is a code owner

@oliveiradan oliveiradan Awaiting requested review from oliveiradan oliveiradan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet