Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing of rocminfo output for ISAs with no features defined #59

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix parsing of rocminfo output for ISAs with no features defined #59

wants to merge 1 commit into from

Conversation

krzysz00
Copy link

@krzysz00 krzysz00 commented Sep 9, 2022

dayatsin-amd
dayatsin-amd approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@dayatsin-amd dayatsin-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. TY. I will merge it from the internal rocminfo repo

rocm-ci pushed a commit that referenced this pull request Sep 15, 2023
@searlmc1
Fix parsing of rocminfo output for ISAs with no features defined
34cc693 
Patch is an internal port of
 #59

Change-Id: Iea84f49a60abce73716a7451960c20ee0d2b7bca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dayatsin-amd dayatsin-amd dayatsin-amd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@krzysz00 @dayatsin-amd