New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid empty-argument lists in C function declarations #46
Open
bertwesarg
wants to merge
13
commits into
ROCm:amd-master
Choose a base branch
from
bertwesarg:avoid-empty-args-decls
base: amd-master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I1baab986d36207b87f6f9ad5e0a45a9cffbea0c8
Change-Id: I50473f8008672772dd4aaf37cbc64472cb50b4a3
Change-Id: I33d01cde41d9a762a8a955a1faccfdef02d8c0ac
Change-Id: Ib8a0df7b7bb0da2e68b5b4d99ce8025de169f317 (cherry picked from commit 29da9a7)
Change-Id: Ib49c8ee034fb7481b21f950490e10b350f2a1b79 (cherry picked from commit 6567c48)
Change-Id: I9688236b06dd167960662b8eecf1a07c93b43fff (cherry picked from commit c9ed0f0)
Change-Id: Id9203aec7800024bd749059a415fb29b8051005a
Change-Id: Ifca31d632726ab83f4c672b46cd9b97f817e757d
Change-Id: I2b00e5d310e6349fc52d5df60aae85f4c06adebe
Change-Id: Ib739cbb7538473afc9744e12d2bd568635e78616 (cherry picked from commit 1d975e5)
Change-Id: I7081b6ad21b038040267067bd73d8a44df46e4ff
… instrumentation; Change-Id: Ibbc411541f5610ce739f3fc1efa1ab7f605220f5 initial commmit Change-Id: I34b360be62c2083819dc5c3acc8268bd69f2f58a
`()` as a function argument list in C is equivalent to `(...)`, i.e, in C you get at most a warning, if it is called with too many arguments. Clarify this situation by explicitly stating `(void)` as argument list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
()
as a function argument list in C is equivalent to(...)
, i.e, in Cyou get at most a warning, if it is called with too many arguments. Clarify
this situation by explicitly stating
(void)
as argument list.