Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fix for ROCm 6.0.0 gfx942 #295

Merged
merged 4 commits into from
Jan 31, 2024

Conversation

r-abishek
Copy link
Member

@kiritigowda Fix for #291

@kiritigowda kiritigowda self-assigned this Jan 31, 2024
Turn Advance build by default
@kiritigowda kiritigowda added BugFix high High Priority - Bug Fix/New Feature labels Jan 31, 2024
atomicInc(&tmp_histogram[pixelR], 1);
atomicInc(&tmp_histogram[pixelG], 1);
atomicInc(&tmp_histogram[pixelB], 1);
atomicAdd(&tmp_histogram[pixelR], 1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is atomicAdd good option. I thought we can't use any atomics

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rrawther Ubuntu build seems to pass with atomicAdd. Ideally, both should work as they did on openCL/cuda/hip, but for some reason only atomicInc() fails on Rocm6.0.0 HIP

Copy link
Contributor

@rrawther rrawther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment

Note update for -D option
@kiritigowda kiritigowda merged commit a5e6cdf into ROCm:develop Jan 31, 2024
10 checks passed
kiritigowda added a commit that referenced this pull request Jan 31, 2024
* modified histogram hip kernel to use atomicAdd instead of atomicInc

* Update CMakeLists.txt

Turn Advance build by default

* Update CMakeLists.txt

Note update for -D option

---------

Co-authored-by: sampath1117 <sampath.rachumallu@multicorewareinc.com>
Co-authored-by: Kiriti Gowda <kiriti.nageshgowda@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BugFix high High Priority - Bug Fix/New Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants