Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor common-fixes for HIP #345

Merged
merged 5 commits into from
May 7, 2024
Merged

Minor common-fixes for HIP #345

merged 5 commits into from
May 7, 2024

Conversation

r-abishek
Copy link
Member

@r-abishek r-abishek commented May 2, 2024 •
edited
Loading

This is a minor PR to add some HIP fixes to match-up tensor code for uniformity:

  • Uses pre-allocated common scratchBufferHip everywhere in Tensor code for scratch HIP memory
  • Uses CHECK_RETURN_STATUS everywhere to adhere to C++17 for hip
  • Removes additional variable usage

@kiritigowda kiritigowda self-assigned this May 3, 2024
@kiritigowda kiritigowda added enhancement New feature or request BugFix labels May 3, 2024
@kiritigowda
Copy link
Collaborator

@r-abishek @LakshmiKumar23 -- is this ready to be merged?

@r-abishek
Copy link
Member Author

@kiritigowda @LakshmiKumar23 This is a minor PR, could be merged

@kiritigowda kiritigowda merged commit 77e14ef into ROCm:develop May 7, 2024
10 checks passed
@r-abishek r-abishek mentioned this pull request May 8, 2024
Merged
kiritigowda pushed a commit that referenced this pull request May 24, 2024
@r-abishek @kiritigowda
Minor common-fixes for HIP (#345)
9c9c6e6 
* Use scratchBufferHip

* minor fix

* remove additional variable use

* Add CHECK_RETURN_STATUS to hip API

* handle fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiritigowda kiritigowda kiritigowda approved these changes

@LakshmiKumar23 LakshmiKumar23 Awaiting requested review from LakshmiKumar23

Assignees

@kiritigowda kiritigowda

Labels
BugFix enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@r-abishek @kiritigowda